Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigQuery: Can iterate over QueryJob results without explicitly calling result() #4350

Merged
merged 1 commit into from
Nov 13, 2017
Merged

BigQuery: Can iterate over QueryJob results without explicitly calling result() #4350

merged 1 commit into from
Nov 13, 2017

Conversation

alixhami
Copy link
Contributor

@alixhami alixhami commented Nov 6, 2017

No description provided.

@alixhami alixhami added the api: bigquery Issues related to the BigQuery API. label Nov 6, 2017
@alixhami alixhami requested review from theacodes and dhermes November 6, 2017 18:53
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 6, 2017
@theacodes theacodes requested a review from tswast November 6, 2017 18:54
@theacodes
Copy link
Contributor

I'd like @tswast or @jba to take a look from a BigQuery perspective as well.

@jba
Copy link
Contributor

jba commented Nov 6, 2017

LGTM, but I will defer to Tim.

@alixhami alixhami mentioned this pull request Nov 7, 2017
Merged
tswast
tswast approved these changes Nov 10, 2017
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

I wonder if this change makes Client.query_rows() unnecessary?

@alixhami
Copy link
Contributor Author

@tswast If the purpose of Client.query_rows() was just to get query results without calling result(), then it would be unnecessary. Are there other uses for it, or should I remove it in another PR?

@alixhami alixhami merged commit d3999a8 into googleapis:master Nov 13, 2017
dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Nov 13, 2017
@dhermes
Post googleapis#4350 cleanup.
17c721a 
This happened because googleapis#4350 was sent before googleapis#4355 was merged.
@dhermes dhermes mentioned this pull request Nov 13, 2017
Merged
dhermes added a commit that referenced this pull request Nov 13, 2017
@dhermes
Post #4350 cleanup. (#4389)
db216c0 
This happened because #4350 was sent before #4355 was merged.
@tswast
Copy link
Contributor

tswast commented Nov 13, 2017

Talked in person. Let's remove query_rows in another PR. I can think of no other uses for it.

chemelnucfin pushed a commit to chemelnucfin/google-cloud-python that referenced this pull request Nov 15, 2017
@alixhami
BigQuery: Can iterate over QueryJob results without explicitly callin…
3b8f557 
…g result() (googleapis#4350)
chemelnucfin pushed a commit to chemelnucfin/google-cloud-python that referenced this pull request Nov 15, 2017
@dhermes
Post googleapis#4350 cleanup. (googleapis#4389)
9a407f5 
This happened because googleapis#4350 was sent before googleapis#4355 was merged.
chemelnucfin pushed a commit to chemelnucfin/google-cloud-python that referenced this pull request Nov 15, 2017
@alixhami
BigQuery: Can iterate over QueryJob results without explicitly callin…
341549d 
…g result() (googleapis#4350)
chemelnucfin pushed a commit to chemelnucfin/google-cloud-python that referenced this pull request Nov 15, 2017
@dhermes
Post googleapis#4350 cleanup. (googleapis#4389)
1a5cfa4 
This happened because googleapis#4350 was sent before googleapis#4355 was merged.
@alixhami alixhami deleted the bq-queryjob-iter branch November 16, 2017 20:12
@alixhami alixhami mentioned this pull request Nov 21, 2017
Merged
@tseaver tseaver mentioned this pull request Jan 4, 2018
Merged
parthea pushed a commit that referenced this pull request Oct 21, 2023
@busunkim96
testing(automl): retry upon InternalServerError [(#4350)](GoogleCloud…
4b8e11b 
…Platform/python-docs-samples#4350)

fixes #4343
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theacodes theacodes theacodes approved these changes

@tswast tswast tswast approved these changes

@dhermes dhermes Awaiting requested review from dhermes

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alixhami @theacodes @jba @tswast @googlebot