-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Demo of usage ideas for a lighter gcloud #438
Conversation
Is there an issue with the current demo? Do we need to delete it? Could this project be in it's own repository like https://github.com/GoogleCloudPlatform/gcloud-python-expenses-demo and then we can link to it somewhere? Also can you rebase to HEAD in master so the PR is merge-able? |
No issue, I just accidentally overwrote it when pushing... As for a new project. Not sure how much frustration it cause to have two 'idiomatic' python client libraries... In any case, writing TodoMVC with the existing library proved to be not very intuitive, and required learning quite a few classes that didn't seem necessary in retrospect. (@proppy wanted me to link this video: https://www.youtube.com/watch?v=o9pEzgHorH0 ) As a developer using the library, this is the interface I would much prefer to use. |
Thanks JB! @elibixby I created https://github.com/GoogleCloudPlatform/gcloud-python-todomvc and initialized with a As far as two different libraries, that is not a good idea. We are happy to take suggestions and have discussions, but they should probably happen in bugs before PRs. Just looking at the code I was distracted by things like I'm currently working on the API surface in #336. I'd agree there are many cases where we could do more with less code and hope to be able to get to that point soon. If you could post the feedback somewhere that'd be great. |
Yes, I think this was confusing because it was submitted as a PR in order to get some feedback on the API, I'm not sure the indent for it was to be merged. @elibixby is just trying to continue the discussion he started in #410 and follow @silvolu suggestion to "show some code". I think this conversation should definitely continue in #336, and @elibixby can give more specific feedback on what was his experience trying to write the gcloud-todos-python app, share some of the code he had to write, and what he would have liked to write instead. |
Yes. Overall, if you can break the feedback into smaller, digestible pieces it's easier to have the conversation. |
|
Not closing this, to leave it open for line commenting, but continuing discussion on #336 |
Closing anyways. Good discussion going in #336 |
Encapsulates session ID / transaction ID, to be marshalled across the wire to another process / host for performing partitioned reads / queries.
Encapsulates session ID / transaction ID, to be marshalled across the wire to another process / host for performing partitioned reads / queries.
Encapsulates session ID / transaction ID, to be marshalled across the wire to another process / host for performing partitioned reads / queries.
Encapsulates session ID / transaction ID, to be marshalled across the wire to another process / host for performing partitioned reads / queries.
Encapsulates session ID / transaction ID, to be marshalled across the wire to another process / host for performing partitioned reads / queries.
* chore(deps): update all dependencies * revert Co-authored-by: Anthonios Partheniou <partheniou@google.com>
* chore(deps): update all dependencies * revert Co-authored-by: Anthonios Partheniou <partheniou@google.com>
* chore(deps): update all dependencies * revert Co-authored-by: Anthonios Partheniou <partheniou@google.com>
- Followup to GoogleCloudPlatform/python-docs-samples#8862 Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
…p/templates/python_library/.kokoro (#438) Source-Link: https://github.com/googleapis/synthtool/commit/bb171351c3946d3c3c32e60f5f18cee8c464ec51 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f62c53736eccb0c4934a3ea9316e0d57696bb49c1a7c86c726e9bb8a2f87dadf
Source-Link: https://github.com/googleapis/synthtool/commit/909573ce9da2819eeb835909c795d29aea5c724e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ddf4551385d566771dc713090feb7b4c1164fb8a698fe52bbe7670b24236565b
* ci: opt in to use multiple projects * lint
* feat: add Deidentify action PiperOrigin-RevId: 471923438 Source-Link: googleapis/googleapis@62995d0 Source-Link: googleapis/googleapis-gen@96ba173 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTZiYTE3MzFjNzEyYTY5Mzk5NWRlNzUzNzg5NDg3ODFhZjI4MzczOSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * revert Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
- [ ] Regenerate this pull request now. PiperOrigin-RevId: 451250442 Source-Link: googleapis/googleapis@cca5e81 Source-Link: googleapis/googleapis-gen@0b219da Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGIyMTlkYTE2MWE4YmRjYzNjNmY3YjJlZmNkODIxMDUxODJhMzBjYSJ9
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
) Source-Link: https://github.com/googleapis/synthtool/commit/0c7b0333f44b2b7075447f43a121a12d15a7b76a Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:08e34975760f002746b1d8c86fdc90660be45945ee6d9db914d1508acdf9a547
* chore(deps): update all dependencies * revert Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@proppy @silvolu
I'm in the process of writing mock objects so people can play around with this usage in the interpreter (and actually run the demo)
For now just looking for input from the community on usage before I continue (about 65% done with initial implementation)