-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BigQuery: removes support for python 3.4 #4597
Conversation
@alixhami It's probably worth
|
@dhermes What should be changed in the docs immediately? I thought we generated the changelog in the release PR with the names of PRs since the last release. |
Just add a note that
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I'd feel better if @jonparrott had a peek
It makes me sad that Python 2.7 is still 91% of our usage. I am not sure I am comfortable with this change; can we discuss it? In particular:
|
It was my idea. ;)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to discuss this before we do it.
@alixhami I don't actually think those stats mean what you think they mean: it would be more in line with them to drop all Python3 support. Is Pandas "core" to BigQuery's mission? If not, let's not have the tail wag the dog here. |
It sounds like the Python 3.4 support decision should be made at a higher level than the BigQuery client library, so I created PR #4681 to address just the BigQuery/Pandas side of things |
Addresses #4587
I queried the pypi dataset to see which versions of Python have been used with google-cloud-bigquery for the last 6 months.