Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery: removes support for python 3.4 #4597

Closed
wants to merge 2 commits into from

Conversation

alixhami
Copy link
Contributor

Addresses #4587

I queried the pypi dataset to see which versions of Python have been used with google-cloud-bigquery for the last 6 months.

python version % of downloads
2.7 91.3%
3.6 4.1%
3.5 2.8%
3.4 1.5%
null 0.3%
other 0.01%

@alixhami alixhami added the api: bigquery Issues related to the BigQuery API. label Dec 15, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 15, 2017
@dhermes
Copy link
Contributor

dhermes commented Dec 15, 2017

@alixhami It's probably worth

  • Updating the docs immediately
  • Making a note in CHANGELOG.md in this PR (so that it's clear in the next release, but worded now)

@alixhami
Copy link
Contributor Author

@dhermes What should be changed in the docs immediately? I thought we generated the changelog in the release PR with the names of PRs since the last release.

@dhermes
Copy link
Contributor

dhermes commented Dec 15, 2017

What should be changed in the docs immediately?

Just add a note that 3.4 is no longer supported.

I thought we generated the changelog in the release PR with the names of PRs since the last release.

CHANGELOG.md is a living file, you can edit it whenever you like. We have not yet edited them outside of release PRs, but there's no hard and fast rule. You could just add a section with an ambiguous version (e.g. 0.x.y) and then put one bullet in there mentioning this PR

Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'd feel better if @jonparrott had a peek

@lukesneeringer
Copy link
Contributor

lukesneeringer commented Dec 15, 2017

It makes me sad that Python 2.7 is still 91% of our usage.

I am not sure I am comfortable with this change; can we discuss it? In particular:

  • I think we should have consistent support across APIs. So, if we are dropping Python 3.4 in BigQuery, we should drop it everywhere.
  • Even with low usage, dropping a Python version is probably a semver-major change. (BigQuery is not 1.0 yet, but see above.)
  • Ideally I would like to tie version support to the EOL dates on the Python versions. This is especially important for when it does come time to drop Python 2.7. I am going to want to point to that bright, shiny, "Python 2.7 is EOL in 2020" sign, and that case is weaker if we are willy nilly about other versions.
    • I get that this is tricky because the Python community is unfortunately amorphous about EOLs.

@theacodes
Copy link
Contributor

theacodes commented Dec 15, 2017 via email

Copy link
Contributor

@lukesneeringer lukesneeringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to discuss this before we do it.

@tseaver
Copy link
Contributor

tseaver commented Dec 21, 2017

@alixhami I don't actually think those stats mean what you think they mean: it would be more in line with them to drop all Python3 support.

Is Pandas "core" to BigQuery's mission? If not, let's not have the tail wag the dog here.

@alixhami
Copy link
Contributor Author

alixhami commented Jan 2, 2018

It sounds like the Python 3.4 support decision should be made at a higher level than the BigQuery client library, so I created PR #4681 to address just the BigQuery/Pandas side of things

@alixhami alixhami closed this Jan 2, 2018
@alixhami alixhami deleted the remove-python-3.4 branch January 5, 2018 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants