args swapped in docs

[ptone]

No description provided.

[coveralls]

Coverage remained the same when pulling 07a0a11 on ptone:patch-1 into b343acf on GoogleCloudPlatform:master.

[dhermes]

LGTM

[dhermes]

@ptone Sorry I am going to revert this, the arguments were correct. The signature of bucket is

    def upload_file(self, filename, key=None):

meaning neither argument should reference a remote path.

I think it'd also be useful to indicate that key is a keyword argument to "fully" reduce confusion.

[ptone]

Did you look at method doc string?

The init docs were wrong, this just makes them match the method docs.

Key is a remote (as in in the bucket) key. Hence the call to new_key in implementation.

??

[dhermes]

Yeah I think the '/local/path.txt and /remote/path/storage.txt could be more explicit as to which is supposed to be a key and which isn't. I'd say one could argue in either direction and there is no reason for ambiguity.

[ptone]

Agree using the kwarg label is more clear. But currently the docs are unambiguously broken as you'll get a 'no such file' error if you pass the strings in the documented order. Swap the order and makes pretty good sense. Follows 'cp src dest' convention. this was a pretty trivial doc improvement.

[dhermes]

Sorry I didn't mean anything by reverting it, just was worried I had too hastily merged something potentially ambiguous.

I'm happy to review if you want to send another PR.

[silvolu]

@ptone could you please sign our CLA before sending more contributions? We cannot otherwise accept those, as trivial as they might be. Thanks!