Firestore: return non existent snapshot if document not found instead of raising NotFound exception #5007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of raising NotFound exception
chemelnucfin
added
api: firestore
googlebot
added
the
cla: yes
tseaver
suggested changes
Mar 9, 2018
| @@ -420,17 +419,11 @@ def get(self, field_paths=None, transaction=None): | |||
| Returns: | |||
| ~.firestore_v1beta1.document.DocumentSnapshot: A snapshot of | |||
| the current document. | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -582,8 +582,7 @@ def _parse_batch_get(get_doc_response, reference_map, client): | |||
| a document factory. | |||
|
|
|||
| Returns: | |||
| Optional[.DocumentSnapshot]: The retrieved snapshot. If the | |||
| snapshot is :data:`None`, that means the document is ``missing``. | |||
| Optional[.DocumentSnapshot]: The retrieved snapshot. | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -420,17 +419,11 @@ def get(self, field_paths=None, transaction=None): | |||
| Returns: | |||
| ~.firestore_v1beta1.document.DocumentSnapshot: A snapshot of | |||
| the current document. | |||
|
|
|||
| Raises: | |||
| ~google.cloud.exceptions.NotFound: If the document does not exist. | |||
| """ | |||
| snapshot_generator = self._client.get_all( | |||
| [self], field_paths=field_paths, transaction=transaction) | |||
| snapshot = _consume_single_get(snapshot_generator) | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
|
||
| # Create a minimal fake client with a dummy response. | ||
| response_iterator = iter([None]) | ||
| read_time = 123 | ||
| snapshot = DocumentSnapshot(None, None, False, read_time, None, None) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
chemelnucfin
force-pushed
the
firestore_to_dict_non_exists
branch
from
1f4d8d4 to
59ef5fc
Compare
|
@tseaver addressed your comments. thanks. I kept a lot of the unittest to not compare to |
tseaver
approved these changes
Mar 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4809