Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-sync with .proto / .textproto files from google-cloud-common. #5351

Merged
merged 1 commit into from
May 21, 2018
Merged

Re-sync with .proto / .textproto files from google-cloud-common. #5351

merged 1 commit into from
May 21, 2018

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented May 21, 2018

Regenerated test_pb2.py by hacking the Makefile to work around machine- specific bits (those changes not committed).

Copied in additional .textproto files, bumping the count of testcasesfrom 83 to 236.

Still doesn't include updates to run tests for listen-*.textproto.

Regenerated 'test_pb2.py' by hacking the 'Makefile' to work around machine-
specific bits (those changes not committed).

Copied in additional '.textproto' files, bumping the count of testcases
from 83 to 236.

Still doesn't include updates to run tests for 'listen-*.textproto'.
@tseaver tseaver added testing api: firestore Issues related to the Firestore API. labels May 21, 2018
@tseaver tseaver requested a review from crwilcox May 21, 2018 18:59
@tseaver tseaver requested a review from lukesneeringer as a code owner May 21, 2018 18:59
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 21, 2018
@tseaver tseaver merged commit 53ef8a2 into googleapis:master May 21, 2018
@tseaver tseaver deleted the firestore-resync_conformance_tests branch May 21, 2018 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants