Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigQuery: Adds Python 3.7 and removes Python 3.4 #5401

Merged
merged 2 commits into from
May 29, 2018
Merged

BigQuery: Adds Python 3.7 and removes Python 3.4 #5401

merged 2 commits into from
May 29, 2018

Conversation

alixhami
Copy link
Contributor

Resolves #5294

@alixhami alixhami added the api: bigquery Issues related to the BigQuery API. label May 29, 2018
@alixhami alixhami requested review from tswast and crwilcox May 29, 2018 18:24
@alixhami alixhami requested a review from tseaver as a code owner May 29, 2018 18:24
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 29, 2018
tswast
tswast reviewed May 29, 2018
View reviewed changes
bigquery/nox.py
@@ -65,7 +65,7 @@ def default(session):


@nox.session
@nox.parametrize('py', ['2.7', '3.5', '3.6'])
@nox.parametrize('py', ['2.7', '3.5', '3.6', '3.7'])

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tseaver
tseaver suggested changes May 29, 2018
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR also needs to update the classifiers in setup.py to indicate that we have dropped support for Python 3.4. Note that 3.4 is still the "system" Python for the LTS versions of RHEL and Ubuntu.

@tswast
Copy link
Contributor

tswast commented May 29, 2018

@crwilcox Shouldn't all setup.py files get the same update?

@tseaver
Copy link
Contributor

tseaver commented May 29, 2018

@tswast Not unless we have made a global choice to drop 3.4 support across all APIs (in which case we should be updating all the corresponding nox.py and setup.py files in lockstep).

@tswast
Copy link
Contributor

tswast commented May 29, 2018

Right, wasn't that what #5295 was about? Or did I misinterpret the intent?

@tswast tswast mentioned this pull request May 29, 2018
Merged
crwilcox
crwilcox approved these changes May 29, 2018
View reviewed changes
Copy link
Contributor

@crwilcox crwilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a comment on also updating system but lgtm

@alixhami alixhami merged commit 8b30a8b into googleapis:master May 29, 2018
@alixhami alixhami deleted the bq-add-3.7 branch May 29, 2018 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

@tswast tswast tswast approved these changes

@crwilcox crwilcox crwilcox approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alixhami @tswast @tseaver @crwilcox @googlebot