Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firestore: don't omit originally-empty map values when processing timestamps. #6050

Merged
merged 2 commits into from
Sep 22, 2018
Merged

Firestore: don't omit originally-empty map values when processing timestamps. #6050

merged 2 commits into from
Sep 22, 2018

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Sep 21, 2018

Closes #5944.

@tseaver tseaver added the api: firestore Issues related to the Firestore API. label Sep 21, 2018
@tseaver tseaver requested a review from theacodes September 21, 2018 17:40
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 21, 2018
@tseaver tseaver requested a review from jba September 21, 2018 17:41
@tseaver tseaver mentioned this pull request Sep 21, 2018
Closed
jba
jba reviewed Sep 21, 2018
View reviewed changes
Copy link
Contributor

@jba jba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tseaver tseaver merged commit dc904ea into googleapis:master Sep 22, 2018
@tseaver tseaver deleted the 5944-firestore-pbs_for_set-w-server_ts-empty_value branch September 22, 2018 00:40
@tseaver tseaver mentioned this pull request Sep 28, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jba jba jba left review comments

@theacodes theacodes Awaiting requested review from theacodes

Assignees
No one assigned
Labels
api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @jba @googlebot