Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix class reference #6153

Merged
merged 1 commit into from
Oct 5, 2018
Merged

Fix class reference #6153

merged 1 commit into from
Oct 5, 2018

Conversation

joar
Copy link
Contributor

@joar joar commented Oct 3, 2018

This stops PyCharm from complaining that my Client instance isn't of type client.py

This stops PyCharm from complaining that my `Client` instance isn't of type `client.py`
@joar joar requested a review from theacodes as a code owner October 3, 2018 17:10
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Oct 3, 2018
@tseaver
Copy link
Contributor

tseaver commented Oct 3, 2018

@joar Thanks for the patch. Can you please do the CLA-signing dance?

@joar
Copy link
Contributor Author

joar commented Oct 4, 2018

@tseaver I tried once and it looked successful, I'll try again.

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Oct 4, 2018
@joar
Copy link
Contributor Author

joar commented Oct 4, 2018

Ah, I just needed to reply to trigger a re-check:

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.
#6153 (comment)

@tseaver
Copy link
Contributor

tseaver commented Oct 5, 2018

@theacodes Any clue why kokoro did not run here?

@tseaver tseaver added api: logging Issues related to the Cloud Logging API. documentation labels Oct 5, 2018
@tseaver tseaver merged commit e0130f5 into googleapis:master Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants