Don't URL-encode slashes in gRPC request headers. #6310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per internal document go/api-url-encoding (approved on 2017-04-20), "the client library will %-encode everything except "/" and unreserved characters, and the server will %-decode everything except "%2F" and %2f" This is currently affecting a private API which passes a resource name (containing slashes) as a query parameter over gRPC.
googlebot
added
the
cla: yes
tseaver
approved these changes
Oct 26, 2018
crwilcox
approved these changes
Oct 26, 2018
tseaver
pushed a commit
that referenced
this pull request
Oct 29, 2018
Per internal document go/api-url-encoding (approved on 2017-04-20), "the client library will %-encode everything except "/" and unreserved characters, and the server will %-decode everything except "%2F" and %2f" This is currently affecting a private API which passes a resource name (containing slashes) as a query parameter over gRPC. (cherry picked from commit e368317)
tseaver
pushed a commit
that referenced
this pull request
Oct 29, 2018
Per internal document go/api-url-encoding (approved on 2017-04-20), "the client library will %-encode everything except "/" and unreserved characters, and the server will %-decode everything except "%2F" and %2f" This is currently affecting a private API which passes a resource name (containing slashes) as a query parameter over gRPC. Toward #6326. (cherry picked from commit e368317)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per internal document go/api-url-encoding (approved on 2017-04-20),
This is currently affecting a private API which passes a resource name
(containing slashes) as a query parameter over gRPC.