Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making sure new docs get built on tags. #645

Merged
merged 1 commit into from
Feb 17, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Feb 14, 2015

A tag is not associated with a branch inherently so
TRAVIS_BRANCH == master is the wrong check.

See my previous comment for context.

A tag is not associated with a branch inherently so
TRAVIS_BRANCH == master is the wrong check.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 14, 2015
@dhermes
Copy link
Contributor Author

dhermes commented Feb 14, 2015

I think I'll just move the 0.4.1 tag after this so those docs get built.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 706768b on dhermes:fix-new-docs-on-tag into f64fc55 on GoogleCloudPlatform:master.

@tseaver
Copy link
Contributor

tseaver commented Feb 17, 2015

LGTM (but I'm missing context to understand #645 (comment)).

dhermes added a commit that referenced this pull request Feb 17, 2015
Making sure new docs get built on tags.
@dhermes dhermes merged commit 9eb8cd4 into googleapis:master Feb 17, 2015
@dhermes
Copy link
Contributor Author

dhermes commented Feb 17, 2015

@tseaver http://googlecloudplatform.github.io/gcloud-python/0.4.1/ never got built (that's why I filed this)

So in order for them to get re-built, I will re-push the 0.4.1 tag.

@dhermes dhermes deleted the fix-new-docs-on-tag branch February 17, 2015 19:21
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
* fix: Add async context manager return types

chore: Mock return_value should not populate oneof message fields

chore: Support snippet generation for services that only support REST transport

chore: Update gapic-generator-python to v1.11.0
PiperOrigin-RevId: 545430278

Source-Link: googleapis/googleapis@601b532

Source-Link: googleapis/googleapis-gen@b3f18d0
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjNmMThkMGY2NTYwYTg1NTAyMmZkMDU4ODY1ZTc2MjA0NzlkN2FmOSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants