-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 'array_contains' to the _COMPARISON_OPERATORS dict, to enable using array_contains in firestore queries. #6481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing array_contains in firestore queries.
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Nov 12, 2018
Prior to this change, I was getting this error:
With the change in this pull request patched locally, my query now appears to work. |
@RohanTalip Thanks for the patch! Can you please exercise the new operator in the unit test for '_enum_from_op_string'. |
@tseaver, done. I don't see the circleci tests actually running any Python / pytest tests, but they passed locally:
|
tseaver
approved these changes
Nov 13, 2018
tseaver
added a commit
that referenced
this pull request
Nov 15, 2018
tseaver
added a commit
that referenced
this pull request
Nov 15, 2018
* Firestore: pick up fixes to GAPIC generator. Closes #6497. Includes changes to generated tests. Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396 * Fix overlong lines introduced in PR #6481.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: firestore
Issues related to the Firestore API.
cla: yes
This human has signed the Contributor License Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to fix #6479.