-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Bigtable: pick up fixes in GAPIC generator. #6492
Conversation
…ient library generator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codegen is busted:
File "/var/code/gcp/bigtable/google/cloud/bigtable/__init__.py", line 21, in <module>
from google.cloud.bigtable.client import Client
File "/var/code/gcp/bigtable/google/cloud/bigtable/client.py", line 40, in <module>
from google.cloud.bigtable.instance import Instance
File "/var/code/gcp/bigtable/google/cloud/bigtable/instance.py", line 20, in <module>
from google.cloud.bigtable.table import Table
File "/var/code/gcp/bigtable/google/cloud/bigtable/table.py", line 37, in <module>
from google.cloud.bigtable import enums
File "/var/code/gcp/bigtable/google/cloud/bigtable/enums.py", line 19, in <module>
class StorageType(object):
File "/var/code/gcp/bigtable/google/cloud/bigtable/enums.py", line 28, in StorageType
UNSPECIFIED = enums.StorageType.STORAGE_TYPE_UNSPECIFIED
AttributeError: module 'google.cloud.bigtable_admin_v2.gapic.enums' has no attribute 'StorageType'
I verified the breakage locally. See googleapis/gapic-generator#2429. |
Hmm, this might have been my breakage: googleapis/gapic-generator#2441 |
We're planning on having artman smoketests run on gapic-generator check-ins so that we don't have these kinda breakages down the road. (ex googleapis/gapic-generator#2443) |
Superseded by #6630. |
Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396 Includes changes to generated tests. Closes #6492.
Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396 Includes changes to generated tests. Closes googleapis#6492.
This PR was generated using Autosynth. 🌈
Here's the log from Synthtool: