Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firestore: pick up changes to GAPIC client config. #6589

Merged
merged 1 commit into from
Nov 20, 2018

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Cloning googleapis.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:90f9d15e9bad675aeecd586725bce48f5667ffe7d5fc4d1e96d51ff34304815b
Status: Image is up to date for googleapis/artman:latest
synthtool > Running generator for google/firestore/artman_firestore.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/firestore-v1beta1.
synthtool > Replaced 'from google.cloud import firestore_v1beta1' in tests/unit/gapic/v1beta1/test_firestore_client_v1beta1.py.
synthtool > Replaced 'client = firestore_v1beta1.FirestoreClient' in tests/unit/gapic/v1beta1/test_firestore_client_v1beta1.py.
synthtool > Cleaned up 0 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 20, 2018
@tseaver tseaver added codegen api: firestore Issues related to the Firestore API. labels Nov 20, 2018
@tseaver
Copy link
Contributor

tseaver commented Nov 20, 2018

Unit tests, coverage, and lint all pass locally for me with this change. Although I can't see the Kokoro log, I was able to get a flaky system test to fail for the new "watch" stuff (see #6605).

@tseaver tseaver changed the title [CHANGE ME] Re-generated firestore to pick up changes in the API or client library generator. Firestore: pick up changes to GAPIC client config. Nov 20, 2018
@tseaver tseaver merged commit 74dc48d into master Nov 20, 2018
@tseaver tseaver deleted the autosynth-firestore branch November 20, 2018 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement. codegen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants