Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigQuery Storage: Update synth to use templates and match lint/coverage #6799

Closed
wants to merge 4 commits into from
Closed

BigQuery Storage: Update synth to use templates and match lint/coverage #6799

wants to merge 4 commits into from

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > You are running the synthesis script directly, this will be disabled in a future release of Synthtool. Please use python3 -m synthtool instead.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:2f6b261ee7fe1aedf238991c93a20b3820de37a343d0cacf3e3e9555c2aaf2ea
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/cloud/bigquery/storage/artman_bigquerystorage_v1beta1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/bigquerystorage-v1beta1.
synthtool > Replaced 'from google.cloud.bigquery.storage_v1beta1.proto' in google/cloud/bigquery_storage_v1beta1/proto/storage_pb2.py.
synthtool > Replaced 'from google.cloud.bigquery.storage_v1beta1.proto' in google/cloud/bigquery_storage_v1beta1/proto/storage_pb2_grpc.py.
synthtool > Replaced 'google-cloud-bigquerystorage' in google/cloud/bigquery_storage_v1beta1/gapic/big_query_storage_client.py.
synthtool > Replaced 'import google.api_core.gapic_v1.method\n' in google/cloud/bigquery_storage_v1beta1/gapic/big_query_storage_client.py.
synthtool > Replaced 'from google.cloud import bigquery_storage_v1beta1' in tests/unit/gapic/v1beta1/test_big_query_storage_client_v1beta1.py.
synthtool > Replaced 'bigquery_storage_v1beta1.BigQueryStorageClient' in tests/unit/gapic/v1beta1/test_big_query_storage_client_v1beta1.py.
synthtool > Replaced 'if transport:' in google/cloud/bigquery_storage_v1beta1/gapic/big_query_storage_client.py.
synthtool > Replaced 'to_grpc_metadata\\(\\n' in google/cloud/bigquery_storage_v1beta1/gapic/big_query_storage_client.py.
synthtool > Replaced 'metadata.append\\(routing_metadata\\)' in google/cloud/bigquery_storage_v1beta1/gapic/big_query_storage_client.py.
synthtool > Replaced 'if channel is not None and credentials is not None:' in google/cloud/bigquery_storage_v1beta1/gapic/transports/big_query_storage_grpc_transport.py.
synthtool > Replaced 'if channel is None:' in google/cloud/bigquery_storage_v1beta1/gapic/transports/big_query_storage_grpc_transport.py.
synthtool > Replaced 'google.api_core.grpc_helpers.create_channel\\(' in google/cloud/bigquery_storage_v1beta1/gapic/transports/big_query_storage_grpc_transport.py.
synthtool > Cleaned up 0 temporary directories.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 30, 2018
@crwilcox crwilcox requested a review from tswast December 1, 2018 01:14
@crwilcox
Copy link
Contributor

crwilcox commented Dec 1, 2018

@tswast I started including our templates in the synth for this but edited the noxfile to match. Please check it over?

@crwilcox crwilcox changed the title [CHANGE ME] Re-generated bigquery_storage to pick up changes in the API or client library generator. Update bigquery_storage synth to use templates and match lint/coverage Dec 1, 2018
@tseaver tseaver added the api: bigquerystorage Issues related to the BigQuery Storage API. label Dec 3, 2018
@tseaver tseaver changed the title Update bigquery_storage synth to use templates and match lint/coverage BigQuery Storage: Update synth to use templates and match lint/coverage Dec 3, 2018
tseaver
tseaver previously approved these changes Dec 3, 2018
View reviewed changes
@tseaver tseaver dismissed their stale review December 3, 2018 18:47

CI failure

tseaver
tseaver suggested changes Dec 3, 2018
View reviewed changes
bigquery_storage/noxfile.py
session.install("-e", local_dep)
session.install("-e", ".")
session.install("-e", "pandas")
session.install("-e", "fastavro")

This comment was marked as spam.

Sign in to view

@crwilcox crwilcox mentioned this pull request Dec 3, 2018
Closed
tswast
tswast reviewed Dec 3, 2018
View reviewed changes
bigquery_storage/noxfile.py
import os
import shutil

This comment was marked as spam.

Sign in to view

bigquery_storage/noxfile.py
session.install('sphinx', 'sphinx_rtd_theme')
session.install('-e', '.[pandas,fastavro]')

shutil.rmtree(os.path.join('docs', '_build'), ignore_errors=True)

This comment was marked as spam.

Sign in to view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast left review comments

@tseaver tseaver tseaver requested changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: bigquerystorage Issues related to the BigQuery Storage API. cla: yes This human has signed the Contributor License Agreement. codegen
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yoshi-automation @crwilcox @tseaver @tswast @googlebot