Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNS] Ensure that ManagedZone:exists() does not misreport True result. #6884

Merged
merged 1 commit into from
Dec 14, 2018
Merged

[DNS] Ensure that ManagedZone:exists() does not misreport True result. #6884

merged 1 commit into from
Dec 14, 2018

Conversation

charles-salmon
Copy link
Contributor

@charles-salmon charles-salmon commented Dec 10, 2018

The behaviour of the MangedZones: get endpoint is such that when only the id field of a non-existent ManagedZone is requested, a 200 status code response with body {} is returned.

This is arguably undesirable behaviour, however this patch serves to ensure that the Python SDK behaves expectedly with the API in its current state.

Is anyone aware of where the best place to leave feedback on the API would be? Is the "Leave Feedback" section on the documentation page appropriate? Is it an open-source project?

The behaviour of the `MangedZones: get` API is such that when only the `id` field of a non-existent `ManagedZone` is requested, a 200 status code response with body `{}` is returned. This is arguably undesirable behaviour, however this patch serves to ensure that the Python SDK works with what is there.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Dec 10, 2018
@charles-salmon
Copy link
Contributor Author

My employer signed the corporate CLA, and added me to the authorized contributors group, approximately an hour ago.

@tseaver tseaver added the api: dns Issues related to the Cloud DNS API. label Dec 10, 2018
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@charles-salmon Thank you very much for digging into this one!

Closes #5818.

@tseaver
Copy link
Contributor

tseaver commented Dec 10, 2018

@charles-salmon Can you reply with literally the text "I signed it!" so the CLA bot will check again?

@charles-salmon
Copy link
Contributor Author

I signed it!

@charles-salmon
Copy link
Contributor Author

(I think the corporate CLA is pending approval.)

@tseaver
Copy link
Contributor

tseaver commented Dec 13, 2018

@theacodes, @JustinBeckwith Can one of you figure out what might be blocking the CLA bot here?

@charles-salmon
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Dec 14, 2018
@charles-salmon
Copy link
Contributor Author

(My employer notified me that the CLA was approved.)

@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 14, 2018
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 14, 2018
@tseaver tseaver merged commit dfb3458 into googleapis:master Dec 14, 2018
@charles-salmon charles-salmon deleted the managed-dns-zones-always-exist branch December 24, 2018 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: dns Issues related to the Cloud DNS API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants