-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DNS] Ensure that ManagedZone:exists()
does not misreport True
result.
#6884
[DNS] Ensure that ManagedZone:exists()
does not misreport True
result.
#6884
Conversation
The behaviour of the `MangedZones: get` API is such that when only the `id` field of a non-existent `ManagedZone` is requested, a 200 status code response with body `{}` is returned. This is arguably undesirable behaviour, however this patch serves to ensure that the Python SDK works with what is there.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
My employer signed the corporate CLA, and added me to the authorized contributors group, approximately an hour ago. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@charles-salmon Thank you very much for digging into this one!
Closes #5818.
@charles-salmon Can you reply with literally the text "I signed it!" so the CLA bot will check again? |
I signed it! |
(I think the corporate CLA is pending approval.) |
@theacodes, @JustinBeckwith Can one of you figure out what might be blocking the CLA bot here? |
I signed it! |
CLAs look good, thanks! |
(My employer notified me that the CLA was approved.) |
The behaviour of the
MangedZones: get
endpoint is such that when only theid
field of a non-existentManagedZone
is requested, a 200 status code response with body{}
is returned.This is arguably undesirable behaviour, however this patch serves to ensure that the Python SDK behaves expectedly with the API in its current state.
Is anyone aware of where the best place to leave feedback on the API would be? Is the "Leave Feedback" section on the documentation page appropriate? Is it an open-source project?