Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing datastore.set_defaults() from all docs. #689

Merged
merged 2 commits into from
Mar 9, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Mar 9, 2015

Fixes #685.

NOTE: I did not remove the actual method from datastore.__init__ but easily could.

Here are the remaining uses of it.

In datastore:

$ git grep set_defaults 
gcloud/datastore/__init__.py:def set_defaults(dataset_id=None, connection=None):
gcloud/datastore/test___init__.py:class Test_set_defaults(unittest2.TestCase):
gcloud/datastore/test___init__.py:        from gcloud.datastore import set_defaults
gcloud/datastore/test___init__.py:        return set_defaults(dataset_id=dataset_id, connection=connection)

And storage:

gcloud/storage/__init__.py:def set_defaults(bucket=None, project=None, connection=None):
gcloud/storage/test___init__.py:class Test_set_defaults(unittest2.TestCase):
gcloud/storage/test___init__.py:        from gcloud.storage import set_defaults
gcloud/storage/test___init__.py:        return set_defaults(bucket=bucket, project=project,
regression/storage.py:storage.set_defaults()

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 9, 2015
@dhermes dhermes added api: datastore Issues related to the Datastore API. docs labels Mar 9, 2015
@tseaver
Copy link
Contributor

tseaver commented Mar 9, 2015

LGTM

@dhermes
Copy link
Contributor Author

dhermes commented Mar 9, 2015

@tseaver Sorry I just pushed another commit onto this also fixing #684.

I'm going to merge it as well (only a few lines and 100% in one file in one docstring). Let me know if there are issues.

dhermes added a commit that referenced this pull request Mar 9, 2015
Removing datastore.set_defaults() from all docs.
@dhermes dhermes merged commit 3c7316e into googleapis:master Mar 9, 2015
@dhermes dhermes deleted the fix-685 branch March 9, 2015 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Purge set_defaults() from all the docs
3 participants