STORAGE: Adding default project in get_connection. #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removing the same fallback in set_default_connection since it calls get_connection().
googlebot
added
the
cla: yes
|
Changes Unknown when pulling da6ad6c on dhermes:storage-default-project-in-connection into * on GoogleCloudPlatform:master*. |
|
LGTM |
dhermes
added a commit
that referenced
this pull request
Mar 12, 2015
…ction STORAGE: Adding default project in get_connection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removing the same fallback in
set_default_connectionsince it callsget_connection().FWIW: I came across this while trying to make implicit auth work in storage. The fact that
get_connectionrequires arguments doesn't work well with_LazyProperty.