-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #6300 - Fix nested schema parsing in insert_rows #7022
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I've requested a few changes in the review comments, but I'll actually handle these today. I appreciate your efforts and want to respect your time. We require 100% unit test coverage, so it'll probably be easier for me to tackle the refactor and unit testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the PR to move the added methods to _helpers.py
with names matching the existing *_to_json
functions in that module. I've updated existing unit tests to cover the new logic.
I was also working on a fix for the issue but ended up being too late as it seems lol. Still, did some unit tests and system tests, maybe those can also be useful. For system tests I used the same issue as the one observed in the bitcoin table and now it's working :). Won't do PR as it doesn't seem necessary, the issue seems already fixed by now. |
Thanks @tswast ! Appreciate the fixes and tests! |
Hi! Here's a potential fix for handling JSON serializing of nested schema in BigQuery (issue 6300).
I think before accepting this it would need tests, but I wanted to hear the maintainer's thoughts on the location of the fix (
client.py
or_helpers.py
). Also, I'm sure there's a better way to do this, but I needed a fix for this problem in my project :)Closes #6300