-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STORAGE: Making Connection.get_all_buckets a standalone method. #716
STORAGE: Making Connection.get_all_buckets a standalone method. #716
Conversation
See comments in googleapis#700 for context.
9c78309
to
4f0c483
Compare
LGTM. I would just move |
Cool. I'll wait on Travis before merging. We've also got a 3 PR backup in the "merged" queue: |
Changes Unknown when pulling 4f0c483 on dhermes:storage-move-get-all-buckets-to-api into * on GoogleCloudPlatform:master*. |
STORAGE: Making Connection.get_all_buckets a standalone method.
See comments in #700 for context.
@tseaver I figured it would be easier to digest moving one method at a time instead of all 4 at once. Still remaining:
NOTE: I re-ran the storage demo to make sure this worked and noticed the very first line was the license. Without the opening
the demo is pretty tough to use. I can add the license back at the end of the file if necessary or even after
# Welcome ...
(/cc @jgeewax).