Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asset: remove unused message exports (via synth). #7262

Closed
wants to merge 1 commit into from
Closed

Asset: remove unused message exports (via synth). #7262

wants to merge 1 commit into from

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Executing /tmpfs/src/git/autosynth/working_repo/asset/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
7b722c1070cd: Pulling fs layer
5fbf74db61f1: Pulling fs layer
ed41cb72e5c9: Pulling fs layer
7ea47a67709e: Pulling fs layer
4639184a1b1d: Pulling fs layer
10cb30cc6115: Pulling fs layer
36a28916316d: Pulling fs layer
4bdbc50dccbb: Pulling fs layer
35adfc0bb864: Pulling fs layer
51158c928f6b: Pulling fs layer
761343cae8d9: Pulling fs layer
f2521f9168aa: Pulling fs layer
abaac31f63d6: Pulling fs layer
cb6fc148c664: Pulling fs layer
6111a44e8ebc: Pulling fs layer
0ca8e129a936: Pulling fs layer
aa80d2e3832a: Pulling fs layer
589bb87c0682: Pulling fs layer
454e63166001: Pulling fs layer
ef627a7d12ce: Pulling fs layer
4c43bb0b7c9e: Pulling fs layer
2301896636aa: Pulling fs layer
f28d06fa4cae: Pulling fs layer
27ff8675d3b2: Pulling fs layer
4639184a1b1d: Waiting
10cb30cc6115: Waiting
36a28916316d: Waiting
4bdbc50dccbb: Waiting
0ca8e129a936: Waiting
aa80d2e3832a: Waiting
35adfc0bb864: Waiting
589bb87c0682: Waiting
51158c928f6b: Waiting
761343cae8d9: Waiting
454e63166001: Waiting
f2521f9168aa: Waiting
abaac31f63d6: Waiting
cb6fc148c664: Waiting
6111a44e8ebc: Waiting
ef627a7d12ce: Waiting
4c43bb0b7c9e: Waiting
2301896636aa: Waiting
f28d06fa4cae: Waiting
27ff8675d3b2: Waiting
7ea47a67709e: Waiting
ed41cb72e5c9: Download complete
5fbf74db61f1: Verifying Checksum
5fbf74db61f1: Download complete
7ea47a67709e: Verifying Checksum
7ea47a67709e: Download complete
7b722c1070cd: Verifying Checksum
7b722c1070cd: Download complete
4639184a1b1d: Verifying Checksum
4639184a1b1d: Download complete
36a28916316d: Verifying Checksum
36a28916316d: Download complete
35adfc0bb864: Verifying Checksum
35adfc0bb864: Download complete
51158c928f6b: Verifying Checksum
51158c928f6b: Download complete
4bdbc50dccbb: Verifying Checksum
4bdbc50dccbb: Download complete
f2521f9168aa: Verifying Checksum
f2521f9168aa: Download complete
7b722c1070cd: Pull complete
10cb30cc6115: Verifying Checksum
10cb30cc6115: Download complete
5fbf74db61f1: Pull complete
ed41cb72e5c9: Pull complete
7ea47a67709e: Pull complete
abaac31f63d6: Verifying Checksum
abaac31f63d6: Download complete
cb6fc148c664: Verifying Checksum
cb6fc148c664: Download complete
761343cae8d9: Verifying Checksum
761343cae8d9: Download complete
6111a44e8ebc: Verifying Checksum
6111a44e8ebc: Download complete
0ca8e129a936: Verifying Checksum
0ca8e129a936: Download complete
aa80d2e3832a: Verifying Checksum
aa80d2e3832a: Download complete
454e63166001: Verifying Checksum
454e63166001: Download complete
4639184a1b1d: Pull complete
4c43bb0b7c9e: Verifying Checksum
4c43bb0b7c9e: Download complete
2301896636aa: Verifying Checksum
2301896636aa: Download complete
589bb87c0682: Verifying Checksum
589bb87c0682: Download complete
f28d06fa4cae: Verifying Checksum
f28d06fa4cae: Download complete
27ff8675d3b2: Verifying Checksum
27ff8675d3b2: Download complete
ef627a7d12ce: Verifying Checksum
ef627a7d12ce: Download complete
10cb30cc6115: Pull complete
36a28916316d: Pull complete
4bdbc50dccbb: Pull complete
35adfc0bb864: Pull complete
51158c928f6b: Pull complete
761343cae8d9: Pull complete
f2521f9168aa: Pull complete
abaac31f63d6: Pull complete
cb6fc148c664: Pull complete
6111a44e8ebc: Pull complete
0ca8e129a936: Pull complete
aa80d2e3832a: Pull complete
589bb87c0682: Pull complete
454e63166001: Pull complete
ef627a7d12ce: Pull complete
4c43bb0b7c9e: Pull complete
2301896636aa: Pull complete
f28d06fa4cae: Pull complete
27ff8675d3b2: Pull complete
Digest: sha256:75bc07ef34a1de9895c18af54dc503ed3b3f3b52e85062e3360a979d2a0741e7
Status: Downloaded newer image for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/cloud/asset/artman_cloudasset_v1beta1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/asset-v1beta1.
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/asset/v1beta1/assets.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/asset-v1beta1/google/cloud/asset_v1beta1/proto/assets.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/asset/v1beta1/asset_service.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/asset-v1beta1/google/cloud/asset_v1beta1/proto/asset_service.proto
synthtool > Placed proto files into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/asset-v1beta1/google/cloud/asset_v1beta1/proto.
synthtool > Replaced 'from google.iam.v1 import policy_pb2 as' in google/cloud/asset_v1beta1/proto/assets_pb2.py.
synthtool > Replaced 'from google.iam.v1 import iam_policy_pb2_grpc as google_dot_iam_dot_v1_dot_policy__pb2' in google/cloud/asset_v1beta1/proto/assets_pb2.py.
synthtool > Replaced "_ASSET.fields_by_name\\['iam_policy'\\].message_type = google_dot_iam_dot_v1_dot_policy__pb2._POLICY" in google/cloud/asset_v1beta1/proto/assets_pb2.py.
synthtool > Replaced '          The full name of the asset. For example: ``//compute.googleapi\n          s.com/projects/my_project_123/zones/zone1/instances/instance1`\n          `. See `Resource Names <https://cloud.google.com/apis/design/r\n          esource_names#full_resource_name>`__ for more information.\n' in google/cloud/asset_v1beta1/proto/assets_pb2.py.
.coveragerc
.flake8
MANIFEST.in
noxfile.py.j2
setup.cfg
Running session blacken
Creating virtualenv using python3.6 in /tmpfs/src/git/autosynth/working_repo/asset/.nox/blacken
pip install --upgrade black
black google tests docs
reformatted /tmpfs/src/git/autosynth/working_repo/asset/google/cloud/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/asset/google/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/asset/google/cloud/asset.py
reformatted /tmpfs/src/git/autosynth/working_repo/asset/google/cloud/asset_v1beta1/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/asset/google/cloud/asset_v1beta1/gapic/enums.py
reformatted /tmpfs/src/git/autosynth/working_repo/asset/google/cloud/asset_v1beta1/gapic/asset_service_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/asset/google/cloud/asset_v1beta1/gapic/transports/asset_service_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/asset/google/cloud/asset_v1beta1/proto/asset_service_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/asset/google/cloud/asset_v1beta1/proto/assets_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/asset/google/cloud/asset_v1beta1/types.py
reformatted /tmpfs/src/git/autosynth/working_repo/asset/google/cloud/asset_v1beta1/gapic/asset_service_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/asset/tests/unit/gapic/v1beta1/test_asset_service_client_v1beta1.py
reformatted /tmpfs/src/git/autosynth/working_repo/asset/google/cloud/asset_v1beta1/proto/assets_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/asset/google/cloud/asset_v1beta1/proto/asset_service_pb2.py
All done! ✨ 🍰 ✨
14 files reformatted, 4 files left unchanged.
Session blacken was successful.
synthtool > Cleaned up 3 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@yoshi-automation yoshi-automation added the api: cloudasset Issues related to the Cloud Asset Inventory API. label Feb 2, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 2, 2019
@tseaver tseaver added the codegen label Feb 4, 2019
tseaver
tseaver reviewed Feb 4, 2019
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crwilcox This looks like a change to gapic-generator, as the underlying .proto files have not changed. While nothing in our code depends on having the shared messages exported from google.asset_v1beta1.types, this kind of change might be breaking for users?

@tseaver tseaver changed the title [CHANGE ME] Re-generated asset to pick up changes in the API or client library generator. Asset: remove unused message exports (via synth). Feb 4, 2019
@crwilcox crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 6, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 6, 2019
@tseaver
Copy link
Contributor

tseaver commented Feb 7, 2019

BigQuery systest failure due to #7300 (unrelated to this PR).

@tseaver
Copy link
Contributor

tseaver commented Feb 7, 2019

Bigtable failures due to #7003 (unrelated).

@tseaver
Copy link
Contributor

tseaver commented Feb 7, 2019

Asset test failures are troubling:

Running session unit-3.5
Creating virtualenv using python3.5 in /tmpfs/src/github/google-cloud-python/asset/.nox/unit-3-5
pip install --upgrade mock pytest pytest-cov
pip install --upgrade -e ../api_core
pip install --upgrade -e ../core
pip install --upgrade -e .
py.test --quiet --cov=google.cloud --cov=tests.unit --cov-append --cov-config=.coveragerc --cov-report= --cov-fail-under=79 tests/unit
....                                                                     [100%]Coverage.py warning: Module google.cloud was previously imported, but not measured (module-not-measured)
Coverage.py warning: Module tests.unit was never imported. (module-not-imported)
FAIL Required test coverage of 79% not reached. Total coverage: 78.43%

I cannot reproduce on my local machine, although I do see the coverage warnings during the unit test runs, and the same missing coverage lines in google/cloud/__init__.py and google/cloud/asset.py.

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Feb 9, 2019
@tseaver tseaver mentioned this pull request Feb 19, 2019
Merged
@tseaver tseaver added needs work This is a pull request that needs a little love. and removed 🚨 This issue needs some love. labels Feb 19, 2019
This was referenced Feb 19, 2019
Closed
Closed
Closed
@tseaver
Copy link
Contributor

tseaver commented Mar 4, 2019

@crwilcox I just checked, and putting the three unused imports back does get the coverage back above the required 79% / 80 % thressholds, which has to be bogus.

@tseaver tseaver mentioned this pull request Mar 4, 2019
Merged
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label May 3, 2019
@busunkim96
Copy link
Contributor

Closing this to force a regen.

@busunkim96 busunkim96 closed this May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver left review comments

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: cloudasset Issues related to the Cloud Asset Inventory API. cla: yes This human has signed the Contributor License Agreement. codegen needs work This is a pull request that needs a little love. 🚨 This issue needs some love.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yoshi-automation @tseaver @busunkim96 @crwilcox @googlebot @yoshi-kokoro