Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing rpc_metadata as part of creating a bidi #7514

Merged
merged 5 commits into from
Mar 27, 2019
Merged

Allow passing rpc_metadata as part of creating a bidi #7514

merged 5 commits into from
Mar 27, 2019

Conversation

crwilcox
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 14, 2019
tseaver
tseaver suggested changes Mar 18, 2019
View reviewed changes
firestore/google/cloud/firestore_v1beta1/watch.py Outdated Show resolved Hide resolved
api_core/google/api_core/bidi.py Show resolved Hide resolved
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Mar 21, 2019
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Mar 26, 2019
@crwilcox crwilcox force-pushed the add-metadata-bidi branch from 416dcd4 to 6304ae6 Compare March 26, 2019 18:52
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Mar 26, 2019
@crwilcox crwilcox force-pushed the add-metadata-bidi branch from 6773468 to 4f16bdb Compare March 26, 2019 22:47
@crwilcox crwilcox merged commit 7f1cfee into googleapis:master Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

@alixhami alixhami Awaiting requested review from alixhami

@theacodes theacodes Awaiting requested review from theacodes

@tswast tswast Awaiting requested review from tswast

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crwilcox @googlebot @tseaver @yoshi-automation