Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Generate client for datacatalog #7708

Merged
merged 4 commits into from
Apr 15, 2019

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Apr 15, 2019

Verified manually that the client works with:

from google.cloud import datacatalog_v1beta1

client = datacatalog_v1beta1.DataCatalogClient()
info = client.lookup_entry(
    sql_resource="bigquery.my-project.schema_examples.array_struct"
)
print(info)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 15, 2019
@tswast tswast marked this pull request as ready for review April 15, 2019 20:32
@tswast tswast requested a review from crwilcox as a code owner April 15, 2019 20:32
@tswast tswast added the api: datacatalog Issues related to the Data Catalog API. label Apr 15, 2019
@tswast tswast requested a review from busunkim96 April 15, 2019 20:37
@tswast
Copy link
Contributor Author

tswast commented Apr 15, 2019

FYI: This client is 100% auto-generated.

@busunkim96
Copy link
Contributor

LGTM.

To get the docs to appear there are handful more steps (copied from Configure Docs in the Python Cloud Client Libraries Playbook).

  1. Create a link between docs and the service docs
    cd docs                                                                                                                                                             
    ln -s ../SERVICE/docs SERVICE
    
  2. Edit docs/requirements.txt to include this service
  3. Edit docs/index.rst to include it in ToC.

@tswast
Copy link
Contributor Author

tswast commented Apr 15, 2019

Thanks for the reminder re: docs. I should really use that playbook as a checklist.

@tswast tswast merged commit da665e8 into googleapis:master Apr 15, 2019
@tswast tswast deleted the b112558014-datacatalog branch April 15, 2019 22:43
parthea pushed a commit that referenced this pull request Jun 4, 2023
* feat: Generate client for datacatalog

* Add Kokoro config.

* Add docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datacatalog Issues related to the Data Catalog API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants