Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing patch() from Bucket.configure_website. #773

Merged
merged 1 commit into from
Mar 30, 2015
Merged

Removing patch() from Bucket.configure_website. #773

merged 1 commit into from
Mar 30, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Mar 28, 2015

Relates to #728.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 28, 2015
@dhermes dhermes mentioned this pull request Mar 28, 2015
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 7cf10dd on dhermes:remove-patch-from-config-website into 4d69bb3 on GoogleCloudPlatform:master.

@dhermes dhermes added the api: storage Issues related to the Cloud Storage API. label Mar 29, 2015
@tseaver
Copy link
Contributor

tseaver commented Mar 30, 2015

I guess the patch() in the testcase methods can be cleaned up at the same time as the ones from #769.

@tseaver
Copy link
Contributor

tseaver commented Mar 30, 2015

LGTM.

This was referenced Mar 30, 2015
Merged
Closed
dhermes added a commit that referenced this pull request Mar 30, 2015
@dhermes
Merge pull request #773 from dhermes/remove-patch-from-config-website
a23b6bd 
Removing patch() from Bucket.configure_website.
@dhermes dhermes merged commit a23b6bd into googleapis:master Mar 30, 2015
@dhermes dhermes deleted the remove-patch-from-config-website branch March 30, 2015 19:40
@tseaver tseaver mentioned this pull request Mar 30, 2015
Closed
@dhermes dhermes mentioned this pull request Apr 9, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhermes @coveralls @tseaver @googlebot