-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BigQuery: Widen range for 'google-cloud-core'. #7969
BigQuery: Widen range for 'google-cloud-core'. #7969
Conversation
There is a unit test failure on the PR branch which is already fixed on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Yeah, sorry that I released something with a test failure. No need to backport the test fix.
Probably the fault of my setup, but a nightly test of my code failed last night with the error This error has no results on Google so thought I'd post here. I fixed the error by adding Probably will be better to update all my dependencies rather than relying on old versions though. In case it's useful, my dependencies now read:
|
@cgparkinson did you save more of the stack trace? We didn't intend for there to be any breaking changes in |
@cgparkinson |
I don't have logs for what exactly got installed from my requirements.txt (this runs on dataflow) but I do have the stack trace.
|
Thanks.
This does confirm you have an older version of google-api-core with the latest version of google-cloud-core. Perhaps you caught us at a time between when the patch release for BigQuery was out, but not for Storage and Pub/Sub yet. Does this still happen when you remove the pin on google-cloud-core? |
I tried removing the pin, but I got the same error. Now with the pin, I get the error:
Looks like I should be specifying the latest version of all of these libraries? edit: specifying latest versions
seemed to fix it. |
Does pinning all to latest work? That's what all our system tests use, so it should. If starting from a fresh virtual env, pinning to latest should have the same effect. If using an existing environment, pip varies depending on the pip version whether it upgrades dependencies or not. Probably safest to pin everything. |
Yep - sorry I edited my comment to that effect. Pinning all to latest does work 👍 Thanks! |
See #7968, "Prep Releases".