Fix #799: Don't pass 'fields' query param to possibly non-existing subscription. #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
LGTM. You mind if we leave #799 open (or file a new one) until the issue gets resolved with the service? |
|
@dhermes I don't mind -- payload size is going to be < MTU even if we don't pass it, though. |
|
Amended the commit to avoid closing #799 at merge. |
|
@tseaver Thanks! I also updated the first message to match, as that would have closed it too. |
|
Changes Unknown when pulling 9bc46c4 on tseaver:799-work_around_cannot_bind_fields_query_param into * on GoogleCloudPlatform:master*. |
tseaver
added a commit
that referenced
this pull request
Apr 7, 2015
…ds_query_param Fix #799: Don't pass 'fields' query param to possibly non-existing subscription.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work around #799 (leaving open while @tmatsuo investigates).
(UPDATED by @dhermes when original commit was amended)