Renaming storage.get_all_buckets to storage.list_buckets. #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Changes Unknown when pulling 7859444 on dhermes:rename-get-all-buckets into * on GoogleCloudPlatform:master*. |
| @@ -25,7 +25,7 @@ | |||
| connection = storage.get_connection() | |||
|
|
|||
| # OK, now let's look at all of the buckets... | |||
| print(demo.get_all_buckets(connection)) # This might take a second... | |||
| print(demo.list_buckets(connection)) # This might take a second... | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Also adding support for optional query parameters of storage.buckets.list.
dhermes
force-pushed
the
rename-get-all-buckets
branch
from
7859444
to
9be17de
Compare
|
@tseaver Addressed issues. PTAL. |
|
LGTM |
dhermes
added a commit
that referenced
this pull request
Apr 9, 2015
Renaming storage.get_all_buckets to storage.list_buckets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adding support for optional query parameters of
storage.buckets.list.Note this rename is "proposed" in #761. If there are issues we don't have to move forward with it.
Relates to #802.