Speech: Increase speech max received msg size to 256 MiB #8338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
CC @lukesneeringer Is there a way we can get the library to generate with the higher message size? It feels a bit weird to have this be our permanent fix. |
busunkim96
approved these changes
Jun 14, 2019
|
Re-ran with the latest |
busunkim96
approved these changes
Jun 17, 2019
atulep
pushed a commit
that referenced
this pull request
Apr 3, 2023
atulep
pushed a commit
that referenced
this pull request
Apr 18, 2023
parthea
pushed a commit
that referenced
this pull request
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5819
This PR increases the default max received message size for speech messages to 256 MiB.
Hardcoded, indeed, but that setting was already not directly available to end users (a full
SpeechGrpcTransportneeds to be passed instead). This PR does not address this aspect.How to test
transports/speech_grpc_transport.py,speechlibrary directory and run the synthtool.Expected result:
transports/speech_grpc_transport.pyare the same as those submitted with this PR.