Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spanner: Adjust gRPC timeouts (via synth). #8445

Merged
merged 1 commit into from
Jun 21, 2019
Merged

Spanner: Adjust gRPC timeouts (via synth). #8445

merged 1 commit into from
Jun 21, 2019

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Executing /tmpfs/src/git/autosynth/working_repo/spanner/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:b79c8c20ee51e5302686c9d1294672d59290df1489be93749ef17d0172cc508d
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/spanner/artman_spanner.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-v1.
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/spanner/v1/mutation.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-v1/google/cloud/spanner_v1/proto/mutation.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/spanner/v1/spanner.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-v1/google/cloud/spanner_v1/proto/spanner.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/spanner/v1/type.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-v1/google/cloud/spanner_v1/proto/type.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/spanner/v1/keys.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-v1/google/cloud/spanner_v1/proto/keys.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/spanner/v1/result_set.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-v1/google/cloud/spanner_v1/proto/result_set.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/spanner/v1/transaction.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-v1/google/cloud/spanner_v1/proto/transaction.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/spanner/v1/query_plan.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-v1/google/cloud/spanner_v1/proto/query_plan.proto
synthtool > Placed proto files into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-v1/google/cloud/spanner_v1/proto.
synthtool > Replaced 'import google.api_core.grpc_helpers\n' in google/cloud/spanner_v1/gapic/transports/spanner_grpc_transport.py.
synthtool > Replaced 'from google.cloud.spanner_v1.proto import spanner_pb2_grpc\n' in google/cloud/spanner_v1/gapic/transports/spanner_grpc_transport.py.
synthtool > Replaced '(\\s+)return google.api_core.grpc_helpers.create_channel\\(\n' in google/cloud/spanner_v1/gapic/transports/spanner_grpc_transport.py.
synthtool > Replaced 'from google.cloud import spanner_v1' in tests/unit/gapic/v1/test_spanner_client_v1.py.
synthtool > Running generator for google/spanner/admin/instance/artman_spanner_admin_instance.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-admin-instance-v1.
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/spanner/admin/instance/v1/spanner_instance_admin.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-admin-instance-v1/google/cloud/spanner_admin_instance_v1/proto/spanner_instance_admin.proto
synthtool > Placed proto files into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-admin-instance-v1/google/cloud/spanner_admin_instance_v1/proto.
synthtool > Replaced "'google-cloud-spanner-admin-instance'" in google/cloud/spanner_admin_instance_v1/gapic/instance_admin_client.py.
synthtool > Replaced 'from google\\.cloud\\.spanner\\.admin\\.instance_v1.proto' in google/cloud/spanner_admin_instance_v1/proto/spanner_instance_admin_pb2_grpc.py.
synthtool > Replaced '====*' in google/cloud/spanner_v1/proto/transaction_pb2.py.
synthtool > Replaced '----*' in google/cloud/spanner_v1/proto/transaction_pb2.py.
synthtool > Replaced '~~~~*' in google/cloud/spanner_v1/proto/transaction_pb2.py.
synthtool > Running generator for google/spanner/admin/database/artman_spanner_admin_database.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-admin-database-v1.
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/spanner/admin/database/v1/spanner_database_admin.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-admin-database-v1/google/cloud/spanner_admin_database_v1/proto/spanner_database_admin.proto
synthtool > Placed proto files into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-admin-database-v1/google/cloud/spanner_admin_database_v1/proto.
synthtool > Replaced "'google-cloud-spanner-admin-database'" in google/cloud/spanner_admin_database_v1/gapic/database_admin_client.py.
synthtool > Replaced 'from google\\.cloud\\.spanner\\.admin\\.database_v1.proto' in google/cloud/spanner_admin_database_v1/proto/spanner_database_admin_pb2_grpc.py.
.coveragerc
.flake8
MANIFEST.in
noxfile.py.j2
setup.cfg
synthtool > Replaced 'include README.rst LICENSE\n' in MANIFEST.in.
Running session blacken
Creating virtualenv using python3.6 in .nox/blacken
pip install black
black docs google tests noxfile.py setup.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_admin_database_v1/gapic/enums.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_admin_database_v1/gapic/database_admin_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_admin_database_v1/gapic/transports/database_admin_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_admin_instance_v1/gapic/enums.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_admin_database_v1/proto/spanner_database_admin_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_admin_instance_v1/gapic/instance_admin_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_admin_instance_v1/gapic/transports/instance_admin_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_admin_database_v1/gapic/database_admin_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_admin_instance_v1/gapic/instance_admin_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_admin_instance_v1/proto/spanner_instance_admin_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_v1/gapic/enums.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_admin_database_v1/proto/spanner_database_admin_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_v1/gapic/transports/spanner_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_v1/gapic/spanner_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_v1/proto/keys_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_v1/proto/keys_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_v1/proto/mutation_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_v1/gapic/spanner_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_v1/proto/query_plan_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_v1/proto/mutation_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_v1/proto/result_set_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_admin_instance_v1/proto/spanner_instance_admin_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_v1/proto/query_plan_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_v1/proto/spanner_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_v1/proto/transaction_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_v1/proto/result_set_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_v1/proto/type_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_v1/proto/type_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/noxfile.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_v1/proto/transaction_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/tests/unit/gapic/v1/test_database_admin_client_v1.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/tests/unit/gapic/v1/test_instance_admin_client_v1.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/tests/unit/gapic/v1/test_spanner_client_v1.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_v1/proto/spanner_pb2.py
All done! ✨ 🍰 ✨
34 files reformatted, 54 files left unchanged.
Session blacken was successful.
synthtool > Cleaned up 2 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@yoshi-automation yoshi-automation added the api: spanner Issues related to the Spanner API. label Jun 20, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 20, 2019
tseaver
tseaver reviewed Jun 20, 2019
View reviewed changes
spanner/google/cloud/spanner_admin_database_v1/gapic/database_admin_client_config.py
@@ -23,7 +23,7 @@
"retry_params_name": "default",
},
"CreateDatabase": {
"timeout_millis": 30000,
"timeout_millis": 3600000,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crwilcox, @snehashah16 Are we actually going to have users wait for an hour before raising en error?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. There is an error in the LRO that blocks instead of returning. This is really the safest option at this time. :(

@tseaver tseaver changed the title [CHANGE ME] Re-generated spanner to pick up changes in the API or client library generator. Spanner: Adjust gRPC timeouts (via synth). Jun 20, 2019
@crwilcox crwilcox merged commit 0e231ca into master Jun 21, 2019
@tseaver tseaver mentioned this pull request Jun 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver left review comments

@crwilcox crwilcox Awaiting requested review from crwilcox

@frankyn frankyn Awaiting requested review from frankyn

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement. codegen
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yoshi-automation @tseaver @crwilcox @googlebot