Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firestore: Add 'Transaction.get' / 'Transaction.get_all'. #8628

Merged
merged 4 commits into from
Jul 15, 2019
Merged

Firestore: Add 'Transaction.get' / 'Transaction.get_all'. #8628

merged 4 commits into from
Jul 15, 2019

Conversation

HemangChothani
Copy link
Contributor

Fixes: #6557

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 10, 2019
@tseaver tseaver added api: firestore Issues related to the Firestore API. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 10, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 10, 2019
@tseaver tseaver changed the title Firestore: Fix refactor transaction layer Firestore: Refactor transaction layer. Jul 10, 2019
@tseaver tseaver changed the title Firestore: Refactor transaction layer. Firestore: Add 'Transaction.get' / 'Transaction.get_all'. Jul 10, 2019
tseaver
tseaver suggested changes Jul 10, 2019
View reviewed changes
firestore/google/cloud/firestore_v1/transaction.py Outdated Show resolved Hide resolved
firestore/tests/unit/v1/test_transaction.py Outdated Show resolved Hide resolved
firestore/tests/unit/v1/test_transaction.py Outdated Show resolved Hide resolved
firestore/tests/unit/v1/test_transaction.py Outdated Show resolved Hide resolved
firestore/tests/unit/v1/test_transaction.py Outdated Show resolved Hide resolved
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 12, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 12, 2019
@tseaver tseaver merged commit 49e7ce3 into googleapis:master Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

@frankyn frankyn Awaiting requested review from frankyn

Assignees
No one assigned
Labels
api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Firestore] Refactor Python Transaction layer to better match other SDKs.
4 participants
@HemangChothani @tseaver @googlebot @yoshi-kokoro