Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firestore: Improve cleanups for 'watch' system tests. #8638

Merged
merged 4 commits into from
Jul 10, 2019
Merged

Firestore: Improve cleanups for 'watch' system tests. #8638

merged 4 commits into from
Jul 10, 2019

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jul 10, 2019

H/t to @pchauhan-qlogic for identifying the need to unsubscribe.

Supersedes #8497.

Closes #6605, #7130.

H/t to @pchauhan-qlogic for identifying the need to unsubscribe.

Supersedes #8497.

Closes #6605, #7130.
@tseaver tseaver added testing api: firestore Issues related to the Firestore API. flaky labels Jul 10, 2019
@tseaver tseaver requested a review from crwilcox July 10, 2019 20:22
@tseaver tseaver requested a review from frankyn as a code owner July 10, 2019 20:22
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 10, 2019
tseaver added 3 commits July 10, 2019 16:34
Exception for 'test_watch_query_order', which requires that we use the
special 'users' collection, in order to take advantage of its index.
@tseaver
Copy link
Contributor Author

tseaver commented Jul 10, 2019

Testing only change to fix flaky CI failures. Merging w/o review.

@tseaver tseaver merged commit 8bb6ef0 into googleapis:master Jul 10, 2019
@tseaver tseaver deleted the 6605-7130-firestore-unflake-watch-systests branch July 10, 2019 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement. flaky testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firestore: 'test_watch_document' systest flakes
2 participants