Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firestore: Add 'should_terminate' predicate for clean BiDi shutdown. #8650

Merged
merged 7 commits into from
Jul 17, 2019
Merged

Firestore: Add 'should_terminate' predicate for clean BiDi shutdown. #8650

merged 7 commits into from
Jul 17, 2019

Commits on Jul 11, 2019

  1. Add 'should_termiate' arg to 'ResumableBidiRp' ctor.

    @tseaver
    tseaver committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    10994de View commit details
    Browse the repository at this point in the history

  2. Check 'should_terminate' in 'ResumableBidiRpc._on_call_done'. 

    Sharpen assertions for other '_on_call_done' testcases.
    @tseaver
    tseaver committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    c13067f View commit details
    Browse the repository at this point in the history

  3. Check 'should_terminate' predicate in 'ResumableBidiRpc._recoverable'.

    @tseaver
    tseaver committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    d5ac85a View commit details
    Browse the repository at this point in the history

  4. Add excplicit coverage for 'should_recover' predicate used by watch.

    @tseaver
    tseaver committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    ffa6a33 View commit details
    Browse the repository at this point in the history

  5. Add 'watch._should_terminate' predicate.

    @tseaver
    tseaver committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    aac5258 View commit details
    Browse the repository at this point in the history

  6. Pass 'watch._should_terminate' predicate to BiDi. 

    Closes #7826.
    @tseaver
    tseaver committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    540eef5 View commit details
    Browse the repository at this point in the history

  7. Fix up shim used by cross-language tests.

    @tseaver
    tseaver committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    714151f View commit details
    Browse the repository at this point in the history