Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging: Map stdlib loglevels to Stackdriver severity enum values. #8837

Merged
merged 7 commits into from
Jul 31, 2019
Merged

Logging: Map stdlib loglevels to Stackdriver severity enum values. #8837

merged 7 commits into from
Jul 31, 2019

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jul 30, 2019

Rather than relying on logging.LogRecord.levelname, which can be changed to arbitrary values, map logging.LogRecord.levelno to the corresponding enum value.

Closes #7213.

Converts Python stdlb log levels to Stackdriver severity values.
@tseaver tseaver added the api: logging Issues related to the Cloud Logging API. label Jul 30, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 30, 2019
@tseaver
Copy link
Contributor Author

tseaver commented Jul 30, 2019

The docs build failed on CircleCI due to a transient network issue (RTD down).

@busunkim96
Copy link
Contributor

Retriggered logging job

@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 31, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 31, 2019
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 31, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 31, 2019
Avoid excessive retries for NotFound.
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 31, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 31, 2019
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 31, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 31, 2019
@tseaver tseaver merged commit 52c89b6 into googleapis:master Jul 31, 2019
@tseaver tseaver deleted the 7213-logging-map-stdlib-loglevel-to-severity branch July 31, 2019 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging: Crash if using non default log level names with CloudLoggingHandler
4 participants