Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging: Remove gRPC size restrictions (4MB default) #8860

Merged

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Aug 1, 2019

Applies fix from #5594 (in response to #5574) to Logging.

Also opened PR grpc/grpc#19810 to see if the defaults can be changed for grpcio.

@busunkim96 busunkim96 added the api: logging Issues related to the Cloud Logging API. label Aug 1, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 1, 2019
logging/synth.py Outdated Show resolved Hide resolved
Co-Authored-By: Tres Seaver <tseaver@palladion.com>
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Aug 1, 2019
@busunkim96 busunkim96 added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Aug 1, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@busunkim96 busunkim96 merged commit 6f0df5d into googleapis:master Aug 1, 2019
@busunkim96 busunkim96 deleted the remove-grpc-restriction-logging branch August 1, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants