Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigQuery: Add support to Dataset for project_ids with org prefix. #8877

Merged
merged 9 commits into from
Aug 22, 2019
Merged

BigQuery: Add support to Dataset for project_ids with org prefix. #8877

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2526dc7
Update dataset.py
emar-kar Jul 30, 2019
533f959
Update test_dataset.py
emar-kar Jul 30, 2019
009ef57
minor chgs
emar-kar Jul 31, 2019
452adf8
*
emar-kar Jul 31, 2019
3e04273
fixed tests issue
emar-kar Aug 1, 2019
7bc877f
minor corrections
emar-kar Aug 5, 2019
4c13b06
major corrections
emar-kar Aug 8, 2019
07dde13
pattern update
emar-kar Aug 12, 2019
e75e0fc
update pattern and tests
emar-kar Aug 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions bigquery/google/cloud/bigquery/dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

import six
import copy
import re

import google.cloud._helpers
from google.cloud.bigquery import _helpers
Expand All @@ -26,6 +27,14 @@
from google.cloud.bigquery.table import TableReference


_PROJECT_PREFIX_PATTERN = re.compile(
r"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we using a multi-line string here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for the readability. I think I’ll switch this to the single line, after correcting the pattern implementation.

(?P<prefix>\S+\:\S+)\.+(?P<remaining>\S*)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we're matching this way, prefix isn't the right term. Should be project_id. Likewise, remaining should be renamed to dataset_id.

Also, instead of \S, we should be matching for characters other than ., that is [^.]+.

We want to match the whole string, so we should probably end this pattern with $.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I renamed parts of the pattern, but the second comment about [^.] seems inappropriate to me. As we know the string could be google.com:project.dataset, that means that dot could be a part of the prefix. I checked couple of variants and as I see \S fits more.

""",
re.VERBOSE,
)


def _get_table_reference(self, table_id):
"""Constructs a TableReference.

Expand Down Expand Up @@ -269,7 +278,7 @@ def from_string(cls, dataset_id, default_project=None):
Args:
dataset_id (str):
A dataset ID in standard SQL format. If ``default_project``
is not specified, this must included both the project ID and
is not specified, this must include both the project ID and
the dataset ID, separated by ``.``.
default_project (str):
Optional. The project ID to use when ``dataset_id`` does not
Expand All @@ -290,13 +299,19 @@ def from_string(cls, dataset_id, default_project=None):
"""
output_dataset_id = dataset_id
output_project_id = default_project
parts = dataset_id.split(".")
with_prefix = _PROJECT_PREFIX_PATTERN.match(dataset_id)
if with_prefix is None:
parts = dataset_id.split(".")
else:
prefix = with_prefix.group("prefix")
remaining = with_prefix.group("remaining")
parts = [prefix, remaining]

if len(parts) == 1 and not default_project:
raise ValueError(
"When default_project is not set, dataset_id must be a "
"fully-qualified dataset ID in standard SQL format. "
'e.g. "project.dataset_id", got {}'.format(dataset_id)
"fully-qualified dataset ID in standard SQL format, "
emar-kar marked this conversation as resolved.
Show resolved Hide resolved
'e.g., "project.dataset_id" got {}'.format(dataset_id)
)
elif len(parts) == 2:
output_project_id, output_dataset_id = parts
Expand Down Expand Up @@ -554,7 +569,7 @@ def from_string(cls, full_dataset_id):
Args:
full_dataset_id (str):
A fully-qualified dataset ID in standard SQL format. Must
included both the project ID and the dataset ID, separated by
include both the project ID and the dataset ID, separated by
``.``.

Returns:
Expand Down
11 changes: 11 additions & 0 deletions bigquery/tests/unit/test_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,11 +186,22 @@ def test_from_string(self):
self.assertEqual(got.project, "string-project")
self.assertEqual(got.dataset_id, "string_dataset")

def test_from_string_w_prefix(self):
cls = self._get_target_class()
got = cls.from_string("prefix:string-project.string_dataset")
self.assertEqual(got.project, "prefix:string-project")
self.assertEqual(got.dataset_id, "string_dataset")

def test_from_string_legacy_string(self):
cls = self._get_target_class()
with self.assertRaises(ValueError):
cls.from_string("string-project:string_dataset")

def test_from_string_w_incorrect_prefix(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add an additional test where the project ID / dataset ID contains an illegal . character. Another way to say that, is the string contains too many "parts". e.g. google.com:project-id.dataset_id.table_id. This should also fail with ValueError.

cls = self._get_target_class()
with self.assertRaises(ValueError):
cls.from_string("google.com.string-project.dataset_id")

def test_from_string_not_fully_qualified(self):
cls = self._get_target_class()
with self.assertRaises(ValueError):
Expand Down