Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "IAM: Remove send/recv msg size limit (via synth)." #8932

Merged
merged 1 commit into from
Aug 2, 2019
Merged

Revert "IAM: Remove send/recv msg size limit (via synth)." #8932

merged 1 commit into from
Aug 2, 2019

Conversation

busunkim96
Copy link
Contributor

Reverts #8908.

Tests passed on IAM because there are no system tests. Options are not getting passed correctly to create_channel

Currently generated as:

            options={
                "grpc.max_send_message_length": -1,
                "grpc.max_receive_message_length": -1,
            },

vs.

google-cloud-python/monitoring/google/cloud/monitoring_v3/gapic/transports/alert_policy_service_grpc_transport.py

Lines 101 to 104 in edcbf6f

options={
"grpc.max_send_message_length": -1,
"grpc.max_receive_message_length": -1,
}.items(),

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 2, 2019
@tseaver tseaver added api: iam Issues related to the Identity and Access Management API. codegen labels Aug 2, 2019
@tseaver tseaver merged commit 8c8e360 into master Aug 2, 2019
@tseaver tseaver deleted the revert-8908-autosynth-iam branch August 2, 2019 18:38
parthea pushed a commit that referenced this pull request Aug 15, 2023
@busunkim96 @tseaver
Revert " Remove send/recv msg size limit (via synth). (#8908)" (#8932)
fc00584 
This reverts commit ca52401f75da136007991a06c6638a92568323af.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

Assignees
No one assigned
Labels
api: iam Issues related to the Identity and Access Management API. cla: yes This human has signed the Contributor License Agreement. codegen
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@busunkim96 @tseaver @googlebot