BigQuery: Add load_table_from_json() method to BQ client #9076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Linking a comment thread for visibility (a question about deep-copying a |
googlebot
added
the
cla: yes
The load_table_from_json() should not directly change the job config passed in as an argument.
plamut
force-pushed
the
iss-4553
branch
4 times, most recently
from
e596212
to
919d30e
Compare
tswast
requested changes
Aug 22, 2019
tswast
approved these changes
Aug 22, 2019
HemangChothani
pushed a commit
to HemangChothani/google-cloud-python
that referenced
this pull request
Aug 29, 2019
…9076) * Add load_table_from_json() method to BQ client * Manipulate a copy of the job config if provided The load_table_from_json() should not directly change the job config passed in as an argument. * Enable schema autodetect if no explicit schema * Cover the path of schema provided in unit tests * Improve tests readability and harden assertions
emar-kar
pushed a commit
to MaxxleLLC/google-cloud-python
that referenced
this pull request
Sep 18, 2019
…9076) * Add load_table_from_json() method to BQ client * Manipulate a copy of the job config if provided The load_table_from_json() should not directly change the job config passed in as an argument. * Enable schema autodetect if no explicit schema * Cover the path of schema provided in unit tests * Improve tests readability and harden assertions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4553.
This PR adds a helper client method
load_table_from_json(). Is supersedes #9070, because GitHub did not detect updates in my topic branch.How to test
Check that the method is similar to e.g.
client.load_table_from_dataframe()and in line with the requirements.P.S.: I will address the last issue comment separately once this is approved (replacing the
_add_rows()helper in system tests is a separate refactoring task IMO).