BigQuery: Autofetch table schema on load if not provided #9108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
plamut
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
Unit tests passing locally, but failing on Kokoro, investigating... Update: Found a non-essential lint issue (unused import), but unit tests also fail on the latest Update 2: Submitted a fix in #9112. |
tswast
requested changes
Aug 27, 2019
A similar check is already performed on the server, and server-side errors are preferred to client errors.
tswast
reviewed
Aug 28, 2019
A mock should raise this error instead of returning a table to trigger schema generation from Pandas dtypes.
plamut
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
Restarted due to failed snippets tests (500 - internal server error) - Kokoro log. |
plamut
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
The |
plamut
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
tswast
requested changes
Sep 4, 2019
tswast
approved these changes
Sep 4, 2019
emar-kar
pushed a commit
to MaxxleLLC/google-cloud-python
that referenced
this pull request
Sep 11, 2019
…9108) * Autofetch table schema on load if not provided * Avoid fetching table schema if WRITE_TRUNCATE job * Skip dataframe columns list check A similar check is already performed on the server, and server-side errors are preferred to client errors. * Raise table NotFound in auto Pandas schema tests A mock should raise this error instead of returning a table to trigger schema generation from Pandas dtypes. * Use list_columns_and_indexes() for names list
emar-kar
pushed a commit
to MaxxleLLC/google-cloud-python
that referenced
this pull request
Sep 18, 2019
…9108) * Autofetch table schema on load if not provided * Avoid fetching table schema if WRITE_TRUNCATE job * Skip dataframe columns list check A similar check is already performed on the server, and server-side errors are preferred to client errors. * Raise table NotFound in auto Pandas schema tests A mock should raise this error instead of returning a table to trigger schema generation from Pandas dtypes. * Use list_columns_and_indexes() for names list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8142.
This PR adds automatic table schema fetching to the
load_table_from_dataframe()method to improve automatic schema detection.No additional system tests, because there already exists a "schema autodetect" test.
How to test
Check that the code is in-line with ticket specs.