Video Intelligence: Enrich VPCSC tests.

[mkudejim]

No description provided.

[mkudejim]

The test fails because the GOOGLE_APPLICATION_CREDENTIALS are set to a non VPC SC project. I have a dedicated service account key file that can be used to set GOOGLE_APPLICATION_CREDENTIALS, how can I add that to the Kokoro test runner?

[busunkim96]

Hi @mkudejim - the approach we've been taking with the VPCSC tests is that a subset of them are run in the CI for this repo (the tests that don't require VPCSC) and that the full set are run elsewhere with VPCSC enabled.

We sorted this out for Monitoring a few weeks ago. You can reference their system tests and some additional setup in the noxfile.py

[mkudejim]

Thank you for the info @busunkim96. I have made it so that VPCSC tests are only run when in vpcsc is set to true. PTAL.

[busunkim96]

@mkudejim The client libraries team and VPCSC team is going to have a meeting in about a week to clarify what we would like from these system tests. We'll hopefully have clearer guidance to provide at that point.

[tseaver]

@busunkim96, @mkudejim I would like for us to back out the changes in this PR, because:

• It removes an actual system test for the client provided by the google-cloud-videouintelligence library.
• The remaining tests for VPCSC functionality do not use the client at all, but make bare HTTP calls using the requests library.

I would also like to back out PR #8607, and look at how to build in real system tests which exercise the VPCSC constraints.

[busunkim96]

@tseaver

I'd also prefer to go the route of real system tests that also exercise VPCSC constraints, but those take longer to write, and the product team folks tasked with writing these tests don't seem to have the bandwith for.

I did not notice that this PR was deleting a previously existing system test. That should definitely be re-added.

I'll send a PR to revert tomorrow morning.