Storage: Restrict version range of google-resumable-media. #9242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crwilcox
force-pushed
the
restrict-resumable-media
branch
from
b129833
to
508c6e7
Compare
crwilcox
commented
Sep 17, 2019
| @@ -31,7 +31,7 @@ | |||
| dependencies = [ | |||
| "google-auth >= 1.2.0", | |||
| "google-cloud-core >= 1.0.3, < 2.0dev", | |||
| "google-resumable-media >= 0.4.0", | |||
| "google-resumable-media >= 0.3.1, < 0.5.0dev", | |||
There was a problem hiding this comment.
This is a match to the manually released 1.19.1
We can rev this to 0.4.0 since this was an unreleased change
@tseaver
There was a problem hiding this comment.
Suggested change
| "google-resumable-media >= 0.3.1, < 0.5.0dev", | |
| "google-resumable-media >= 0.4.0, < 0.5.0dev", |
There was a problem hiding this comment.
ISTM that >= 0.3.1, != 0.4.0, < 0.5dev is the right specification, until GRMP has a new version (might be 1.0.0?) to include deliberately: the reality is that 0.3.1 and 0.4.1 are near identical, and the storage client works with the older one.
tseaver
changed the title
|
Superseded by #9240. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.