feat(bigquery): add support for custom QueryJobConfig in BigQuery.cursor.execute method #9278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
TobKed
force-pushed
the
support-custom-config-for-cursor-execute
branch
2 times, most recently
from
942cfff
to
dd170ac
Compare
TobKed
force-pushed
the
support-custom-config-for-cursor-execute
branch
from
dd170ac
to
7d23584
Compare
plamut
changed the title
plamut
suggested changes
Sep 24, 2019
…ute cursor method
|
Thanks for feedback @plamut . I've applied changes suggested by you however still waiting for Kokoro check. |
plamut
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
plamut
added
the
kokoro:force-run
yoshi-kokoro
removed
kokoro:force-run
|
Kokoro - Recommender check has failed however logs are empty. @plamut do you know maybe why it failed? I have no clue what is the reason. |
|
@TobKed Seems like flakiness, saw the same on a few other PRs as well. I will try restarting the jobs. Update: Actually, it seems to be a real issue in the Recommender library, not just flakiness. It currently happens on all PRs, and it's not related to the changes made here. |
plamut
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
plamut
approved these changes
Sep 25, 2019
|
@plamut thanks for feedback! Good luck with fixing Kokoro :) |
tswast
approved these changes
Sep 25, 2019
There was a problem hiding this comment.
LGTM. I'm a bit concerned about deviating from the DB-API spec for execute(), but I see we already deviate due to job_id.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My change allows to support
use_legacy_sql.