Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(speech): add v1p1beta1 systests for longrunning / streaming recognize #9287

Merged
merged 4 commits into from
Sep 30, 2019
Merged

test(speech): add v1p1beta1 systests for longrunning / streaming recognize #9287

merged 4 commits into from
Sep 30, 2019

Conversation

wangbill-google
Copy link
Contributor

New test case for v1p1beta1 which tests 3 APIs.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 24, 2019
@busunkim96
Copy link
Contributor

Would it be possible to get the changes into one PR? It looks like they're the same tests, just against different versions of the API. In addition, it looks like the system tests are failing speech.

_ ERROR collecting tests/system/gapic/v1p1beta1/test_system_speech_v1p1beta1.py _
ImportError while importing test module '/tmpfs/src/github/google-cloud-python/speech/tests/system/gapic/v1p1beta1/test_system_speech_v1p1beta1.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
tests/system/gapic/v1p1beta1/test_system_speech_v1p1beta1.py:21: in <module>
    from google.cloud import storage
E   ImportError: cannot import name 'storage' from 'google.cloud' (/tmpfs/src/github/google-cloud-python/core/google/cloud/__init__.py)

@wangbill-google
Copy link
Contributor Author

Yes, we can delete this line:
from google.cloud import storage

@tseaver tseaver added testing api: speech Issues related to the Speech-to-Text API. labels Sep 25, 2019
@tseaver tseaver changed the title Update test_system_speech_v1p1beta1.py Speech: Add v1p1beta1 systests for longrunning / streaming recognize. Sep 25, 2019
@busunkim96 busunkim96 changed the title Speech: Add v1p1beta1 systests for longrunning / streaming recognize. test(speech): add v1p1beta1 systests for longrunning / streaming recognize Sep 26, 2019
@busunkim96 busunkim96 merged commit 57734a3 into googleapis:master Sep 30, 2019
atulep pushed a commit that referenced this pull request Apr 3, 2023
@wangbill-google @busunkim96
test(speech): add v1p1beta1 systests for longrunning / streaming reco…
d5d38e8 
…gnize (#9287)
atulep pushed a commit that referenced this pull request Apr 6, 2023
@wangbill-google @busunkim96
test(speech): add v1p1beta1 systests for longrunning / streaming reco…
88977a6 
…gnize (#9287)
atulep pushed a commit that referenced this pull request Apr 18, 2023
@wangbill-google @busunkim96
test(speech): add v1p1beta1 systests for longrunning / streaming reco…
6420326 
…gnize (#9287)
parthea pushed a commit that referenced this pull request Oct 22, 2023
@wangbill-google @busunkim96
test(speech): add v1p1beta1 systests for longrunning / streaming reco…
7992e46 
…gnize (#9287)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

Assignees
No one assigned
Labels
api: speech Issues related to the Speech-to-Text API. cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wangbill-google @busunkim96 @tseaver @googlebot