feat(bigquery): expose customer managed encryption key for ML models #9302
Conversation
googlebot
added
the
cla: yes
| @@ -25,6 +25,7 @@ | |||
| from google.api_core import datetime_helpers | |||
| from google.cloud.bigquery import _helpers | |||
| from google.cloud.bigquery_v2 import types | |||
| from google.cloud.bigquery.table import EncryptionConfiguration | |||
There was a problem hiding this comment.
It seems wrong for EncryptionConfiguration to live in the table module now that it's used for tables and models. Let's create a new encryption_configuration model for this to live. (Similar to external_config.)
We can make an alias in the table module to keep this from being a breaking change.
| @@ -21,6 +21,8 @@ | |||
| import google.cloud._helpers | |||
| from google.cloud.bigquery_v2.gapic import enums | |||
|
|
|||
| KMS_KEY_NAME = "projects/1/locations/global/keyRings/1/cryptoKeys/1" | |||
There was a problem hiding this comment.
I know this is a unit test, but we're supposed to discourage use of global location. Let's change this to us.
HemangChothani
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
@tswast PTAL. |
…hange location in key
| @@ -70,99 +70,6 @@ def _verifySchema(self, schema, resource): | |||
| self._verify_field(field, r_field) | |||
|
|
|||
|
|
|||
| class TestEncryptionConfiguration(unittest.TestCase): | |||
There was a problem hiding this comment.
Can we please keep one test to ensure that from google.cloud.bigquery.table import EncryptionConfiguration continues to work? I don't want to make this feature into breaking change.
bigquery/tests/unit/test_table.py
Outdated
| @@ -1118,7 +1046,9 @@ def test_clustering_fields_setter_w_none_noop(self): | |||
| self.assertFalse("clustering" in table._properties) | |||
|
|
|||
| def test_encryption_configuration_setter(self): | |||
| from google.cloud.bigquery.table import EncryptionConfiguration | |||
| from google.cloud.bigquery.encryption_configuration import ( | |||
There was a problem hiding this comment.
I meant that we need to test that the old location needs to continue to work.
| from google.cloud.bigquery.encryption_configuration import ( | |
| # Previously, the EncryptionConfiguration class was in the table module, not the | |
| # encryption_configuration module. It was moved to support models encryption. | |
| # This test import from the table module to ensure that the previous location | |
| # continues to function as an alias. | |
| from google.cloud.bigquery.table import ( |
HemangChothani
deleted the
Bigquery_expose_CMEK_functionality_for_ML_models
branch
Fixes: #9251