-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api_core): finalize during close of 'ResumableBidiRpc'. #9337
Merged
tseaver
merged 3 commits into
googleapis:master
from
tseaver:8616-9008-api_core-finalize-on-bidi-close
Oct 2, 2019
Merged
fix(api_core): finalize during close of 'ResumableBidiRpc'. #9337
tseaver
merged 3 commits into
googleapis:master
from
tseaver:8616-9008-api_core-finalize-on-bidi-close
Oct 2, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tseaver
added
api: pubsub
Issues related to the Pub/Sub API.
api: core
api: firestore
Issues related to the Firestore API.
labels
Sep 27, 2019
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Sep 27, 2019
crwilcox
reviewed
Sep 27, 2019
crwilcox
reviewed
Oct 1, 2019
@crwilcox PTAL |
LGTM, but this will need to be rewritten to conform to conventionalcommits |
crwilcox
approved these changes
Oct 2, 2019
I'll fix that in the merge commit. |
busunkim96
pushed a commit
to busunkim96/google-cloud-python
that referenced
this pull request
Oct 3, 2019
…s#9337) Avoid blocking for ill-behaved daemon threads during BiDi shutdown. Closes googleapis#8616, googleapis#9008.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: core
api: firestore
Issues related to the Firestore API.
api: pubsub
Issues related to the Pub/Sub API.
cla: yes
This human has signed the Contributor License Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid blocking for ill-behaved daemon threads during BiDi shutdown.
Closes #8616, #9008.