Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fake commit. #942

Closed
wants to merge 3 commits into from
Closed

Fake commit. #942

wants to merge 3 commits into from

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Jun 23, 2015

@tseaver This is to make sure #940 works.

@dhermes dhermes added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 23, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 23, 2015
@dhermes dhermes force-pushed the fake-commit-test-coveralls branch from f4e5d16 to a66b43d Compare June 23, 2015 20:21
@tseaver
Copy link
Contributor

tseaver commented Jun 23, 2015

LOL: failed lint:

************* Module gcloud.datastore.query
C: 83, 0: Unnecessary parens after 'print' keyword (superfluous-parens)

@dhermes
Copy link
Contributor Author

dhermes commented Jun 23, 2015

@tseaver Yep and I also discovered tox -e docs failed. The nice thing is that pylint won't complain about that if from __future__ import print_function is in the module.

@dhermes
Copy link
Contributor Author

dhermes commented Jun 23, 2015

@tseaver We can address that in #943. This commit is not intended to be merged.

More importantly, 99.99% did not result in a failure from coveralls.io

I'll dig in now and see what I can do.

@dhermes
Copy link
Contributor Author

dhermes commented Jun 23, 2015

@tseaver I signed in to coveralls.io and changed the settings, let's hope this handles it

screen_shot_014

@dhermes
Copy link
Contributor Author

dhermes commented Jun 23, 2015

I should mention that both the "COVERAGE THRESHOLD FOR FAILURE" and "COVERAGE DECREASE THRESHOLD FOR FAILURE" boxes were empty (which I take to mean unset) before I updated the values.

@dhermes
Copy link
Contributor Author

dhermes commented Jun 23, 2015

@tseaver I'm closing out. It looks like tweaking the settings did the trick. Feel free to re-open if you don't think this resolves it.

@dhermes dhermes closed this Jun 23, 2015
@dhermes dhermes deleted the fake-commit-test-coveralls branch June 23, 2015 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhermes @tseaver @googlebot