Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(bigquery): remove location parameter from samples #9500

Closed
wants to merge 1 commit into from
Closed

docs(bigquery): remove location parameter from samples #9500

wants to merge 1 commit into from

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Oct 19, 2019 •
edited
Loading

Closes #9499.

The parameter can sometimes confuse new BigQuery developers. Since location autodetection now works pretty well, the parameter can be removed from code samples for better clarity.

There didn't seem to be any samples specifically demonstrating how to set the location, thus removed that parameter from all of them.

PR checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut
docs(bigquery): remove location parameter from samples
ed35ef9 
The parameter can sometimes confuse new BigQuery developers. Since
location autodetection now works pretty well, the parameter can be
removed from code samples for better clarity.
@plamut plamut added api: bigquery Issues related to the BigQuery API. type: docs Improvement to the documentation for an API. labels Oct 19, 2019
@plamut plamut requested a review from a team October 19, 2019 11:16
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 19, 2019
@emar-kar
Copy link
Contributor

As I'm working with the refactoring project of the BigQuery samples, your PR might cause conflicts with the already existing one. There is a link to it in the issue.

@plamut
Copy link
Contributor Author

plamut commented Oct 19, 2019 •
edited
Loading

@emar-kar Thanks for the notice. I see that the samples have been split into multiple modules. I can make the same set of changes based on the existing PR, and submit my PR to the other PR branch. Then we can merge both set of changes into the main repository without conflicts.

@plamut plamut added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 19, 2019
@emar-kar
Copy link
Contributor

It will be great! And you can leave the snippets.py without changes because it is under deprecation and as soon as I'm making a new sample file, I'm deleting the same test from it.

@plamut plamut mentioned this pull request Oct 19, 2019
Merged
@plamut
Copy link
Contributor Author

plamut commented Oct 19, 2019

Superseded by a pull request opened directly against a related pull request to avoid unnecessary merge conflicts in the samples code.

@plamut plamut closed this Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BigQuery: Remove location parameter from query code samples
3 participants
@plamut @emar-kar @googlebot