Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bigtable): add 'client_options' / 'admin_client_options' to Client #9517

Merged
merged 2 commits into from
Oct 24, 2019
Merged

feat(bigtable): add 'client_options' / 'admin_client_options' to Client #9517

merged 2 commits into from
Oct 24, 2019

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 22, 2019

Toward #8475.

Supersedes #9289.

@tseaver tseaver added api: bigtable Issues related to the Bigtable API. api: bigtableadmin Issues related to the Cloud Bigtable Admin API API. labels Oct 22, 2019
@tseaver tseaver requested a review from busunkim96 October 22, 2019 22:05
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 22, 2019
@busunkim96 busunkim96 mentioned this pull request Oct 22, 2019
Closed
19 tasks
@tseaver tseaver changed the title feat(bigtable): add 'client_info' / 'admin_client_info' to Client. feat(bigtable): add 'client_info' / 'admin_client_info' to Client Oct 22, 2019
@tseaver
Copy link
Contributor Author

tseaver commented Oct 22, 2019

@busunkim96 This looks to be the last open PR to complete #8475.

@busunkim96 busunkim96 changed the title feat(bigtable): add 'client_info' / 'admin_client_info' to Client feat(bigtable): add 'client_options' / 'admin_client_options' to Client Oct 22, 2019
busunkim96
busunkim96 approved these changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this!

bigtable/google/cloud/bigtable/client.py Outdated Show resolved Hide resolved
bigtable/google/cloud/bigtable/client.py Outdated Show resolved Hide resolved
bigtable/google/cloud/bigtable/client.py Outdated Show resolved Hide resolved
@tseaver @busunkim96
Apply suggestions from code review
cde9ee9 
Co-Authored-By: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 24, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 24, 2019
@tseaver
Copy link
Contributor Author

tseaver commented Oct 24, 2019

Flaky systest reported in #9535.

@tseaver tseaver merged commit 2beaa95 into googleapis:master Oct 24, 2019
@tseaver tseaver deleted the 8475-bigtable-add-client_options-support branch October 24, 2019 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

@frankyn frankyn Awaiting requested review from frankyn

Assignees
No one assigned
Labels
api: bigtable Issues related to the Bigtable API. api: bigtableadmin Issues related to the Cloud Bigtable Admin API API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tseaver @busunkim96 @googlebot @yoshi-kokoro