Adding base client class in core. #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This is pre-work in googleapis#952, but came up in googleapis#933 as well.
dhermes
force-pushed
the
client-parent-in-core
branch
from
b692cd3 to
3068473
Compare
This behavior is needed to the dataset client as well, so we put it on the base class. The JSON client class also checks for a project.
This was referenced Jun 26, 2015
|
@tseaver PTAL |
This was referenced Jul 1, 2015
|
LGTM |
dhermes
added a commit
that referenced
this pull request
Jul 2, 2015
Adding base client class in core.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pre-work in #952, but came up in #933 as well.