Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(bigquery): document how to achieve higher write limit and add tests #9574

Merged
merged 4 commits into from
Nov 1, 2019

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Oct 31, 2019

Fixes #9539.

This PR documents how to achieve the higher write limit on streaming inserts, and extends unit tests to cover that case (i.e. no row insert IDs).

How to test

As mentioned in the last issue comment - check that the new code sample and the docs are indeed valid, and that new tests are sound

@plamut plamut added api: bigquery Issues related to the BigQuery API. type: docs Improvement to the documentation for an API. labels Oct 31, 2019
@plamut plamut requested a review from a team October 31, 2019 10:33
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 31, 2019
bigquery/tests/unit/test_client.py Outdated Show resolved Hide resolved
bigquery/tests/unit/test_client.py Outdated Show resolved Hide resolved
bigquery/tests/unit/test_client.py Outdated Show resolved Hide resolved
@plamut
Copy link
Contributor Author

plamut commented Nov 1, 2019

Renamed the methods along with the files as well for consistency.

@plamut plamut requested a review from tseaver November 1, 2019 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. type: docs Improvement to the documentation for an API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigQuery: provide option to omit 'insertId' for 'insert_rows' and 'insert_rows_json'.
4 participants