Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(spanner): harden 'test_transaction_batch_update*' systests against partial success + abort #9579

Merged
merged 4 commits into from
Nov 1, 2019
Merged

test(spanner): harden 'test_transaction_batch_update*' systests against partial success + abort #9579

merged 4 commits into from
Nov 1, 2019

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 31, 2019

Closes #9534.

@tseaver tseaver added testing api: spanner Issues related to the Spanner API. flaky labels Oct 31, 2019
@tseaver tseaver requested review from crwilcox and emar-kar October 31, 2019 17:05
@tseaver tseaver requested a review from frankyn as a code owner October 31, 2019 17:05
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 31, 2019
@tseaver tseaver mentioned this pull request Oct 31, 2019
Merged
@tseaver
Copy link
Contributor Author

tseaver commented Oct 31, 2019

Ugh, a different flaky systest, similar to #8474, rears its ugly head. It is like this one, in that the back-end in transaction.batch_update is returning partial success, even though the error code is ABORTED (which makes partial success bogus, AFAICT).

@tseaver tseaver changed the title test(spanner): unflake 'test_transaction_batch_update_and_execute_dml' systest test(spanner): harden 'test_transaction_batch_update*' systests against partial success + abort Oct 31, 2019
@emar-kar
Copy link
Contributor

emar-kar commented Nov 1, 2019

LGTM

@tseaver tseaver merged commit 48359eb into googleapis:master Nov 1, 2019
@tseaver tseaver deleted the 9534-spanner-unflake-batch-dml-systest branch November 1, 2019 19:34
@yoshi-automation yoshi-automation mentioned this pull request Jan 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emar-kar emar-kar emar-kar approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

@frankyn frankyn Awaiting requested review from frankyn

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement. flaky testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spanner: 'test_transaction_batch_update_and_execute_dml' systest flakes with 'None' status code.
3 participants
@tseaver @emar-kar @googlebot